Adds new function in MeshManager for performing convex decomposition #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
9 tasks
iche033
changed the title
Signed-off-by: Ian Chen <[email protected]>
iche033
force-pushed
the
convex_decomposition_6
branch
from
9a530b0
to
dfec149
Compare
Signed-off-by: Ian Chen <[email protected]>
iche033
force-pushed
the
convex_decomposition_6
branch
from
b264bad
to
f3c20cc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #585 +/- ##
==========================================
- Coverage 83.66% 80.47% -3.19%
==========================================
Files 79 80 +1
Lines 10264 13542 +3278
==========================================
+ Hits 8587 10898 +2311
- Misses 1677 2644 +967 ☔ View full report in Codecov by Sentry. |
ahcorde
approved these changes
Mar 14, 2024
azeey
reviewed
Mar 14, 2024
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
9 tasks
azeey
requested changes
Mar 14, 2024
Signed-off-by: Ian Chen <[email protected]>
azeey
approved these changes
Mar 14, 2024
9 tasks
9 tasks
iche033
added a commit
that referenced
this pull request
Apr 8, 2024
…585) Signed-off-by: Ian Chen <[email protected]>
iche033
added a commit
that referenced
this pull request
Apr 8, 2024
…585) Signed-off-by: Ian Chen <[email protected]>
mjcarroll
added a commit
that referenced
this pull request
Apr 11, 2024
* Various Bazel adjustments for linting (#582) Signed-off-by: Michael Carroll <[email protected]> * Prepare for 5.5.1 (#586) Signed-off-by: Addisu Z. Taddese <[email protected]> * Adds new function in MeshManager for performing convex decomposition (#585) Signed-off-by: Ian Chen <[email protected]> * Add new function in MeshManager to merge all submeshes of a mesh into one (#588) --------- Signed-off-by: Ian Chen <[email protected]> * Fix bazel build (#592) Signed-off-by: Shameek Ganguly <[email protected]> * Remove pessimizing move (#593) Signed-off-by: Shameek Ganguly <[email protected]> Signed-off-by: Michael Carroll <[email protected]> Co-authored-by: Shameek Ganguly <[email protected]> --------- Signed-off-by: Michael Carroll <[email protected]> Signed-off-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Ian Chen <[email protected]> Signed-off-by: Shameek Ganguly <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]> Co-authored-by: Ian Chen <[email protected]> Co-authored-by: shameekganguly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
replaces #583
Summary
Adds function for doing convex decomposition using the header only library V-HACD.
The new function take a submesh and returns a vector of decomposed submeshes. Currently a couple of parameters are exposed:
_maxConvexHulls: max number of convex hulls to produce_voxelResolution: resolution of voxels to use when decomposing the submeshThese default values for these parameters are lower than the default values provided in V-HACD for a faster convex decomposition process as the process with original values could take quite some time for complex meshes.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.