Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ign -> gz CMake, Config, and Example Files migration : gz-cmake #274

Merged
merged 3 commits into from
Jul 12, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon commented Jul 9, 2022

See: gazebo-tooling/release-tools#698

NOTE: THIS MUST BE REBASE MERGED!! Files were moved!

Description

Migrates IgnXXX.cmake files, examples, and configured files.

Hard-tocks

  • ignition..in and ign..in files have been hard migrated since they're used internally. References to them in gz-cmake have also been migrated.

Tick-tocks

  • All IgnXXX.cmake files have been migrated to Gz.

Some downstream packages use IgnPython.cmake and IgnBenchmark.cmake, symlinks have been installed for tick-tocking (though warnings cannot be emitted.)

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 9, 2022
methylDragon added a commit that referenced this pull request Jul 9, 2022
methylDragon added a commit that referenced this pull request Jul 9, 2022
methylDragon added a commit that referenced this pull request Jul 9, 2022
methylDragon added a commit that referenced this pull request Jul 9, 2022
methylDragon added a commit that referenced this pull request Jul 9, 2022
methylDragon added a commit that referenced this pull request Jul 9, 2022
methylDragon added a commit that referenced this pull request Jul 9, 2022
methylDragon added a commit that referenced this pull request Jul 9, 2022
methylDragon added a commit that referenced this pull request Jul 9, 2022
methylDragon added a commit that referenced this pull request Jul 9, 2022
methylDragon added a commit that referenced this pull request Jul 9, 2022
methylDragon added a commit that referenced this pull request Jul 9, 2022
methylDragon added a commit that referenced this pull request Jul 9, 2022
methylDragon added a commit that referenced this pull request Jul 9, 2022
methylDragon added a commit that referenced this pull request Jul 9, 2022
methylDragon added a commit that referenced this pull request Jul 9, 2022
methylDragon added a commit that referenced this pull request Jul 10, 2022
methylDragon added a commit that referenced this pull request Jul 10, 2022
methylDragon added a commit that referenced this pull request Jul 10, 2022
@methylDragon methylDragon force-pushed the migrate_ign_cmake_files branch 2 times, most recently from 57b3f55 to e70b715 Compare July 10, 2022 05:23
methylDragon added a commit that referenced this pull request Jul 10, 2022
methylDragon added a commit that referenced this pull request Jul 10, 2022
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jul 11, 2022
scpeters added a commit to gazebosim/gz-sim that referenced this pull request Jul 11, 2022
@scpeters
Copy link
Member

testing this branch for macOS and windows CI in gazebosim/gz-sim#1586

@scpeters
Copy link
Member

looks like the IgnPython symlink doesn't work on windows:

--- stderr: gz-math7
CMake Error at CMakeLists.txt:82 (include):
  include could not find requested file:

    IgnPython

@scpeters
Copy link
Member

looks like the IgnPython symlink doesn't work on windows:

--- stderr: gz-math7
CMake Error at CMakeLists.txt:82 (include):
  include could not find requested file:

    IgnPython

could we install a dummy IgnPython file that just includes GzPython? it could probably include a cmake warning in that file (similar to our ignition/*/config.hh files)

@methylDragon methylDragon force-pushed the migrate_ign_cmake_files branch 2 times, most recently from da08f0a to a49c239 Compare July 11, 2022 22:17
@methylDragon
Copy link
Contributor Author

looks like the IgnPython symlink doesn't work on windows:

--- stderr: gz-math7
CMake Error at CMakeLists.txt:82 (include):
  include could not find requested file:

    IgnPython

could we install a dummy IgnPython file that just includes GzPython? it could probably include a cmake warning in that file (similar to our ignition/*/config.hh files)

I managed to fix it another way, I think I needed to add a prefix. Build is running now: Build Status

@methylDragon methylDragon enabled auto-merge (rebase) July 12, 2022 03:15
@methylDragon methylDragon merged commit 61a7f05 into main Jul 12, 2022
@methylDragon methylDragon deleted the migrate_ign_cmake_files branch July 12, 2022 03:21
methylDragon added a commit that referenced this pull request Jul 12, 2022
methylDragon added a commit that referenced this pull request Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants