Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the OGRE plugin path discovery portable #101

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

seanyen
Copy link

@seanyen seanyen commented Jun 30, 2020

Instead of checking the platform, check the existence of pkg-config to accommodate more environments.

@seanyen seanyen requested a review from mxgrey as a code owner June 30, 2020 21:10
@chapulina
Copy link
Contributor

@seanyen , mind signing your commit? We're using DCO on Ignition just like ROS 2. Thanks!

@seanyen
Copy link
Author

seanyen commented Jul 1, 2020

@chapulina Thanks for the reminder! Now I signed my commits.

@scpeters
Copy link
Member

scpeters commented Jul 7, 2020

@osrf-jenkins run tests please

@chapulina chapulina merged commit 361b762 into gazebosim:ign-cmake0 Jul 13, 2020
j-rivero pushed a commit that referenced this pull request Aug 25, 2021
* make the OGRE plugin path discovery portable (#101)
* Remove bitbucket-pipelines.yml (#181)

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina mentioned this pull request Sep 1, 2021
6 tasks
srmainwaring pushed a commit to srmainwaring/gz-cmake that referenced this pull request Mar 1, 2022
* make the OGRE plugin path discovery portable (gazebosim#101)
* Remove bitbucket-pipelines.yml (gazebosim#181)

Signed-off-by: Louise Poubel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants