Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize and add more context to Gazebo migration guides #480

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Aug 9, 2024

Adds a "Gazebo Classic Migration" section to the menu and puts the gz11 side-by-side and ros2-gazebo-classic tutorials under it. This does not change the URLs to those tutorials and is only meant to clean up the main menu. I've also added, the "Gazebo Classic Migration" page containing some context about Gazebo Classic and all the resources that help with migration.

image

@azeey azeey requested a review from caguero August 9, 2024 17:23
@azeey azeey requested a review from mabelzhang as a code owner August 9, 2024 17:23
Copy link
Contributor

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some links that don't work in the Gazebo Classic Migration tutorial. Will they work when we merge the PR?

@azeey
Copy link
Contributor Author

azeey commented Aug 9, 2024

I see some links that don't work in the Gazebo Classic Migration tutorial. Will they work when we merge the PR?

Which links?

@caguero
Copy link
Contributor

caguero commented Aug 9, 2024

I see some links that don't work in the Gazebo Classic Migration tutorial. Will they work when we merge the PR?

Which links?

Migrating ROS 2 packages that use Gazebo Classic

I'm checking the link that's generated when you click on View File. Maybe there is different link when everything is deployed? Just checking...

@azeey
Copy link
Contributor Author

azeey commented Aug 9, 2024

I see some links that don't work in the Gazebo Classic Migration tutorial. Will they work when we merge the PR?

Which links?

Migrating ROS 2 packages that use Gazebo Classic

I'm checking the link that's generated when you click on View File. Maybe there is different link when everything is deployed? Just checking...

Oh yeah, that's it's not going to link properly on github. You can download and preview the generated website from the Deploy action summary though.

[Harmonic](https://gazebosim.org/api/sim/8/ardupilot.html)
- [Basic description of SDF worlds](sdf_worlds)
- [Feature Comparison with Gazebo Classic](comparison)
- [Documentation for ros_gz](ros2_integration)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we link with the ros2_overview tutorial instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking at https://gazebosim.org/docs/harmonic/ros2_overview/ and I don't see any links to the ros2_integration document or any of the other ros2 tutorials available except the ros_installation. Would you be able to update that? In the mean time, I'd prefer we keep the ros2_integration link here.

@caguero
Copy link
Contributor

caguero commented Aug 9, 2024

I see some links that don't work in the Gazebo Classic Migration tutorial. Will they work when we merge the PR?

Which links?

Migrating ROS 2 packages that use Gazebo Classic
I'm checking the link that's generated when you click on View File. Maybe there is different link when everything is deployed? Just checking...

Oh yeah, that's it's not going to link properly on github. You can download and preview the generated website from the Deploy action summary though.

That works for me, thanks!

@azeey azeey requested a review from caguero August 15, 2024 15:26
@azeey azeey merged commit a86d6e6 into gazebosim:master Aug 15, 2024
5 checks passed
@azeey azeey deleted the reorganize_gz_classic_migration branch August 15, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants