Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brew doctor: unstable instead of fail, ignore proj@7 warnings #627

Merged
merged 3 commits into from
Jan 24, 2022

Conversation

scpeters
Copy link
Contributor

Repeat of #626 for install_bottle jobs.

Needed to fix the following:

#BEGIN SECTION: brew doctor analysis
+ brew missing
+ brew missing
+ brew list
+ grep '^sdl$'
+ brew doctor
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: Some installed formulae are deprecated or disabled.
You should find replacements for the following formulae:
  proj@7
Build step 'Execute shell' marked build as failure

Repeat of #626 for install_bottle jobs.

Signed-off-by: Steve Peters <[email protected]>
@scpeters
Copy link
Contributor Author

@scpeters
Copy link
Contributor Author

added a change to address a critical build farm issue: mark brew doctor complaints as unstable instead of failures

testing: Build Status https://build.osrfoundation.org/view/os_homebrew/job/ignition_cmake2-install_bottle-homebrew-amd64/585/

Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay. I asked one non-blocking question about running brew doctor while also suppressing known issues.

# if proj@7 installed, skip brew doctor
# remove this line when gdal stops depending on a deprecated version of proj
# https://github.com/Homebrew/homebrew-core/issues/82441
brew list | grep '^proj@7$' || brew doctor || echo MARK_AS_UNSTABLE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since brew doctor is now a soft failure rather than a hard one does it make sense to run it unconditionally and live with with the warning or otherwise let it warn about other issues while suppressing the proj complaint?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to suppress the proj@7 complaint since we don't have any control over that; that's an issue with homebrew-core. brew doctor usually complains about out-of-date Xcode version on our build machines, which I like to be notified about.

@scpeters scpeters changed the title Ignore brew doctor proj@7 warning for install jobs brew doctor: unstable instead of fail, ignore proj@7 warnings Jan 24, 2022
@scpeters scpeters merged commit 3734256 into master Jan 24, 2022
@scpeters scpeters deleted the scpeters/brew_doctor_gdal_install branch January 24, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants