-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
brew doctor: unstable instead of fail, ignore proj@7 warnings #627
Conversation
Repeat of #626 for install_bottle jobs. Signed-off-by: Steve Peters <[email protected]>
testing with this branch https://build.osrfoundation.org/job/ignition_garden-install_bottle-homebrew-amd64/74/ |
Signed-off-by: Steve Peters <[email protected]>
added a change to address a critical build farm issue: mark testing: https://build.osrfoundation.org/view/os_homebrew/job/ignition_cmake2-install_bottle-homebrew-amd64/585/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks okay. I asked one non-blocking question about running brew doctor while also suppressing known issues.
# if proj@7 installed, skip brew doctor | ||
# remove this line when gdal stops depending on a deprecated version of proj | ||
# https://github.com/Homebrew/homebrew-core/issues/82441 | ||
brew list | grep '^proj@7$' || brew doctor || echo MARK_AS_UNSTABLE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since brew doctor
is now a soft failure rather than a hard one does it make sense to run it unconditionally and live with with the warning or otherwise let it warn about other issues while suppressing the proj complaint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to suppress the proj@7
complaint since we don't have any control over that; that's an issue with homebrew-core. brew doctor
usually complains about out-of-date Xcode version on our build machines, which I like to be notified about.
Repeat of #626 for install_bottle jobs.
Needed to fix the following: