Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore brew doctor warnings for proj@7 #626

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Ignore brew doctor warnings for proj@7 #626

merged 1 commit into from
Jan 20, 2022

Conversation

scpeters
Copy link
Contributor

Needed by osrf/homebrew-simulation#1790, gazebosim/gz-common#290

+ echo '#BEGIN SECTION: brew doctor analysis'
#BEGIN SECTION: brew doctor analysis
+ brew missing
+ brew missing
+ brew list
+ grep '^sdl$'
+ brew doctor
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: Some installed formulae are deprecated or disabled.
You should find replacements for the following formulae:
  proj@7

@scpeters scpeters mentioned this pull request Jan 19, 2022
Merged
7 tasks
jennuine
jennuine approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but maybe wait for ✔️ from @j-rivero since this process is new to me?

@scpeters
Copy link
Contributor Author

LGTM, but maybe wait for ✔️ from @j-rivero since this process is new to me?

testing with Build Status https://build.osrfoundation.org/job/ignition_common-ci-pr_any-homebrew-amd64/1272/

I think it's safe to merge, so I will do so

@scpeters scpeters merged commit 5271d46 into master Jan 20, 2022
@scpeters scpeters deleted the scpeters/brew_doctor_ignore_proj7 branch January 20, 2022 00:40
scpeters added a commit that referenced this pull request Jan 20, 2022
@scpeters
Ignore brew doctor proj@7 warning for install jobs
b0c9444 
Repeat of #626 for install_bottle jobs.

Signed-off-by: Steve Peters <[email protected]>
This was referenced Jan 20, 2022
Merged
Merged
scpeters added a commit that referenced this pull request Jan 24, 2022
@scpeters
brew doctor: unstable instead of fail, ignore proj@7 warnings (#627)
3734256 
Repeat of #626 for install_bottle jobs.

Signed-off-by: Steve Peters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennuine jennuine jennuine approved these changes

@j-rivero j-rivero Awaiting requested review from j-rivero j-rivero is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scpeters @jennuine