Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps in harmonic : ci_matching_branch/bump_harmonic_sdformat14 #1

Merged
merged 4 commits into from
Aug 3, 2023

Conversation

azeey
Copy link
Collaborator

@azeey azeey commented Jul 28, 2023

@scpeters
Copy link
Contributor

this would be a little easier to review if the rm -rf focal was in a separate commit than the other changes, but I can manage as is

ubuntu/debian/tests/build Outdated Show resolved Hide resolved
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey force-pushed the ci_matching_branch/bump_harmonic_sdformat14 branch from 568bab8 to fdb76cb Compare August 1, 2023 22:36
@azeey
Copy link
Collaborator Author

azeey commented Aug 1, 2023

this would be a little easier to review if the rm -rf focal was in a separate commit than the other changes, but I can manage as is

Yeah, sorry about that. I've separated the changes in two commits and addressed your feedback in the third.

ubuntu/debian/compat Outdated Show resolved Hide resolved
@azeey
Copy link
Collaborator Author

azeey commented Aug 3, 2023

Test build: Build Status

@azeey azeey merged commit d8b39c1 into main Aug 3, 2023
@azeey azeey deleted the ci_matching_branch/bump_harmonic_sdformat14 branch August 3, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants