Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Pose_TEST patch (send upstream) #1

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Fix Pose_TEST patch (send upstream) #1

merged 1 commit into from
Nov 30, 2020

Conversation

scpeters
Copy link
Contributor

The nightly builds are failing to apply the Pose_TEST patch:

Build Status https://build.osrfoundation.org/job/ign-math7-debbuilder/20/

patching file src/Pose_TEST.cc
Hunk #1 FAILED at 152.
1 out of 1 hunk FAILED
dpkg-source: info: the patch has fuzz which is not allowed, or is malformed

I've queued another build with this branch:

Build Status https://build.osrfoundation.org/job/ign-math7-debbuilder/21/

@scpeters
fix Pose_TEST patch
2ccdedf 
Signed-off-by: Steve Peters <[email protected]>
@j-rivero
Copy link
Contributor

We need to send the patch to upstream sources since many different places are suffering from the same problem. I'll leave this open to remember about it.

@j-rivero j-rivero changed the title Fix Pose_TEST patch Fix Pose_TEST patch (send upstream) Nov 30, 2020
@j-rivero
Copy link
Contributor

We need to send the patch to upstream sources since many different places are suffering from the same problem. I'll leave this open to remember about it.

Just saw that we have gazebosim/gz-math#161 for this. Merging this one.

@j-rivero j-rivero merged commit 071c802 into main Nov 30, 2020
@scpeters scpeters deleted the scpeters/fix_pose_test_patch branch November 30, 2020 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-rivero j-rivero j-rivero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scpeters @j-rivero