Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relocate manifest.json to ./public/ #4890

Merged
merged 3 commits into from
Apr 9, 2018
Merged

Relocate manifest.json to ./public/ #4890

merged 3 commits into from
Apr 9, 2018

Conversation

dojineko
Copy link
Contributor

@dojineko dojineko commented Apr 8, 2018

This pull-request relocate manifest.json to ./public/ from ./public/icons/.
(According to Google Developers manifest.json seems to be placed in Root.)
ref: https://developers.google.com/web/fundamentals/web-app-manifest/

Background

Current version gatsby-plugin-manifest (1.0.17) create manifest.json to ./public/icons.
However, generated manifest.json's icon-path contains icons/ prefix.
Therefore, it is supposed to refer to a path which does not exist on the browser.
like: localhost:9000/icons/icons/*****.png

screenshot

@gatsbybot
Copy link
Collaborator

gatsbybot commented Apr 8, 2018 •
edited
Loading

Deploy preview for gatsbygram ready!

Built with commit 8ea2be6

https://deploy-preview-4890--gatsbygram.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Apr 8, 2018 •
edited
Loading

Deploy preview for using-drupal ready!

Built with commit 8ea2be6

https://deploy-preview-4890--using-drupal.netlify.com

KyleAMathews
KyleAMathews suggested changes Apr 8, 2018
View reviewed changes
Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR fixing this!

packages/gatsby-plugin-manifest/src/gatsby-node.js Outdated
@@ -9,7 +9,7 @@ function generateIcons(icons, srcIcon) {
return Promise.map(icons, icon => {
const size = parseInt(icon.sizes.substring(0, icon.sizes.lastIndexOf(`x`)))
const imgPath = `./public/` + icon.src
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you have this use path.join as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KyleAMathews fixed it! 😇

packages/gatsby-plugin-manifest/src/gatsby-node.js Outdated
@@ -40,8 +40,8 @@ exports.onPostBuild = (args, pluginOptions) =>
fs.mkdirSync(iconPath)
}

fs.writeFileSync(`${iconPath}/manifest.json`, JSON.stringify(manifest))

fs.writeFileSync(`./public/manifest.json`, JSON.stringify(manifest))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moonmeister what was iconPath supposed to be for? It looks like everything is in the root of the public folder anyways?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iconPath calculated from the the icons array. It's important for making sure icons and (the way I wrote it) the manifest into the path specified as the icons path. Thus if someone manually supplies an icons array with a path different then what I've used in the default array everything gets put to that correct path. If we're moving manifest out of the folder it it does not affect the manifest.

@moonmeister
Copy link
Contributor

@dojineko Thanks for catching this and submitting a PR. I it in the icons folder just to keep everything clean together. There's nothing in the w3 spec that I'm seeing that says it has to be in the root.

What I do recall from my research is this: if the manifest is at /icons/manifest.json along side the icons, the icon paths in the manifest only need to be /icon48.png, they don't need the /icons folder specified.

I don't have a preference whether the manifest gets moved back to root. Thanks again for your help on this.

moonmeister
moonmeister approved these changes Apr 9, 2018
View reviewed changes
Copy link
Contributor

@moonmeister moonmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. the more I think about it leaving the manifest.json in the root is the simpler solution cause of some random things. All looks good, thanks for moving it to path.join wish I'd known it existed.Thanks

@pieh pieh mentioned this pull request Apr 9, 2018
Closed
@KyleAMathews KyleAMathews merged commit 3dafecf into gatsbyjs:master Apr 9, 2018
@KyleAMathews
Copy link
Contributor

Thanks! Will release shortly.

KyleAMathews pushed a commit that referenced this pull request Apr 18, 2018
@benjaminhoffman @KyleAMathews
Refactors email signup form to use gatsby-plugin-mailchimp (#4589)
1d36bca 
* Refactors email signup form to use gatsby-plugin-mailchimp

* Adds two babel plugins

* Refactors email signup form to use gatsby-plugin-mailchimp

* Adds two babel plugins

* Refactors from async/await to then/catch

* Removes useless gatsby-node change

* Bumps dep version

* Refactors email signup form to use gatsby-plugin-mailchimp

Signed-off-by: benjamin hoffman <[email protected]>

* Adds two babel plugins

Signed-off-by: benjamin hoffman <[email protected]>

* Consistently use `npm` instead of `yarn` [Docs][Review] (#4607)

* Remove yarn from “Deploying”

TODO: no sure if to remove/convert yarn example from GitLab instructions on this page, since GitLab might rely on yarn and not npm.

* Use npm instead of yarn in Style Guide

* Minor: guides -> Guides

* npm instead of Yarn in GitHub Pages setup

* GitLab yarn -> npm

* Revert "Use npm instead of yarn in Style Guide"

This reverts commit ac72f11.

For our internal stuff, we do want people to use Yarn as we commit yarn.lock files.

* Blog: Hexo yarn -> npm

* Package readme: yarn -> npm

Signed-off-by: benjamin hoffman <[email protected]>

* remark-prismjs: add aliases for languages (#4688)

* remark-prismjs: refactor tests into pre and code

* remark-prismjs: add aliases for languages

This allows specifying aliases for languages when using prismjs.

Fixes #4549

Signed-off-by: benjamin hoffman <[email protected]>

* internally use Map() in getState()'s pages (#4681)

In an attempt to debug issue #4680 and generally improve
the performance of Gatsby as a whole, we swapped out the Array that
`getState()` uses internally with a `Map()`.
Signed-off-by: benjamin hoffman <[email protected]>

* Publish

 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]

Signed-off-by: benjamin hoffman <[email protected]>

* Add direct link to download VS Community 2015
Signed-off-by: benjamin hoffman <[email protected]>

* Add CodeBushi to showcase

replacing hunterchang.com with CodeBushi
Signed-off-by: benjamin hoffman <[email protected]>

* Add Gatsby Starter Tailwind
Signed-off-by: benjamin hoffman <[email protected]>

* Add philippczernitzki.me to Showcase (#4710)


Signed-off-by: benjamin hoffman <[email protected]>

* Also point to download page and update description
Signed-off-by: benjamin hoffman <[email protected]>

* [www] Fix logic to determine selected plugin from list (#4706)

* fix logic to determine selected plugin from list

* fix selected style for scoped packages

Signed-off-by: benjamin hoffman <[email protected]>

* Fix #4503 (#4698)

* Fix #4503

- added check to make sure node exists before tying to get descendents and delete
- added test case that calls deleteNode on an undefined node

* formatting

* formatting

Signed-off-by: benjamin hoffman <[email protected]>

* Change the name & description of gatsbyjs.org (#4713)

Instead of:
You can now view gatsby-starter-default in the browser.

It’s now:
You can now view gatsbyjs.org in the browser.
Signed-off-by: benjamin hoffman <[email protected]>

* Publish

 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]

Signed-off-by: benjamin hoffman <[email protected]>

* Add docs page on setting up Linux for Gatsby (#4716)

* new page an title

* add in outline

* build tools

* node-install

* links and preamble

* debian too

* Update gatsby-on-linux.md

* Copy edits

* Copy edits

* Update gatsby-on-linux.md

Signed-off-by: benjamin hoffman <[email protected]>

* Document gatsby-link being only for internal links (#4720)

Add an example of a component which could be used to automatically
choose <a> or gatsby-link depending on the destination.

Resolves #4662.
Signed-off-by: benjamin hoffman <[email protected]>

* Add support for the Styled Components Babel plugin (#4722)


Signed-off-by: benjamin hoffman <[email protected]>

* Publish

 - [email protected]
 - [email protected]
 - [email protected]

Signed-off-by: benjamin hoffman <[email protected]>

* Fix typo on Linux docs page (#4728)

* new page an title

* add in outline

* build tools

* node-install

* links and preamble

* debian too

* Update gatsby-on-linux.md

* Copy edits

* Copy edits

* Update gatsby-on-linux.md

* typo you, your

* typo you, your

Signed-off-by: benjamin hoffman <[email protected]>

* Add Gatsby Starter Bloomer (#4731)

Add new starter info to documentation
Signed-off-by: benjamin hoffman <[email protected]>

* Add SSR support to i18next article (#4582)

* Add SSR support to i18next article

* Add note

translate hoc (react-i18next) cause component not able to SSR

Signed-off-by: benjamin hoffman <[email protected]>

* Add WebGazer to Showcase sites on README
Signed-off-by: benjamin hoffman <[email protected]>

* [gatsby-transformer-remark] Don't generate AST for same node multiple times in parallel. (#4734)

If we are already generating AST for given node - wait for result of that.
Signed-off-by: benjamin hoffman <[email protected]>

* Queue page requests to wp endpoints (#4735)

* Wrap better-queue with Promise syntax that resolves when the queue
drains

* Queue requests for wp objects.
Added config to set concurreny of the requests

* Use concurrency instead of batchSize

* Fix passing the config to the getPages function
Fix how options are passed in to better-queue

Signed-off-by: benjamin hoffman <[email protected]>

* [www] Move Plugins page from /packages to /plugins (#4705)

* move plugins page from /packages to /plugins

* revert package slug to /packages

* /packages instead of /plugins as path for packages

* fix formatting

* Update index.js

* Update index.js

* Fix sidebar

Signed-off-by: benjamin hoffman <[email protected]>

* Publish

 - [email protected]
 - [email protected]

Signed-off-by: benjamin hoffman <[email protected]>

* Add gatsby-starter-i18n-lingui (#4741)


Signed-off-by: benjamin hoffman <[email protected]>

* Add smakosh.com to Showcase (#4678)


Signed-off-by: benjamin hoffman <[email protected]>

* [remark-autolink-headers] Show anchor when :focus'ed (#4739)


Signed-off-by: benjamin hoffman <[email protected]>

* [gatsby-source-wordpress] support for exlcuded manufacturers and types (#4538)

* [gatsby-source-wordpress] support for excluded manufacturers and types

* [gatsby-source-wordpress] first take on globe exclusion matching

* [gatsby-source-wordpress] route based globbing

* [gatsby-source-wordpress] correcint excludeRoutes README

* [gatsby-source-wordpress] iterate excludedRoutes

* [gatsby-source-wordpress] adding minimatch as dependency

* [gatsby-source-wordpress] renaming concurrentRequests parameter for consistency

also added doc note for concurrentRequests and fixed bug in getPages call that prevented verbose output

* [gatsby-source-wordpress] adding better-queue as explicit dependency

Signed-off-by: benjamin hoffman <[email protected]>

* [gatsby-source-wordpress] Link Parent pages to pages (#4747)

* Generic implementation for all node types

* Update gatsby-node.js

* Update normalize.js

Signed-off-by: benjamin hoffman <[email protected]>

* Publish

 - [email protected]

Signed-off-by: benjamin hoffman <[email protected]>

* Publish

 - [email protected]
 - [email protected]

Signed-off-by: benjamin hoffman <[email protected]>

* Adding a new site built with Gatsby (#4752)

Migrated from my blog from WordPress to Gatsby
Signed-off-by: benjamin hoffman <[email protected]>

* Update CONTRIBUTING_ES.md

Updated a bit of translation.
Still needs a unified stlye for the markdown IMO
Signed-off-by: benjamin hoffman <[email protected]>

* Update README.md (#4764)

* Update README.md

* Update README.md

Signed-off-by: benjamin hoffman <[email protected]>

* Add HS Hackathons to projects list
Signed-off-by: benjamin hoffman <[email protected]>

* updating scrape.js for gatsbygram (#4777)

* updating scrape.js for gatsbygram

* Update gatsbygram images

Signed-off-by: benjamin hoffman <[email protected]>

* Add seo docs (#4766)

* add seo link

* Create seo.md

* Typo

* Typo

* Copy edits

Signed-off-by: benjamin hoffman <[email protected]>

* Correct potential miscommunication in SEO doc (#4778)

It's implying that we don't client render — which we do — so remove that fragment since not important to message of the sentence.
Signed-off-by: benjamin hoffman <[email protected]>

* add Bartosz Dominiak site to showcase (#4784)


Signed-off-by: benjamin hoffman <[email protected]>

* Publish

 - [email protected]

Signed-off-by: benjamin hoffman <[email protected]>

* Add OutboundLink component to gatsby-plugin-google-analytics + track links on gatsbyjs.org (#4786)

* Add OutBoundLink component to gatsby-plugin-google-analytics

* Track outbound links on gatsbyjs.org

* Fix link errors + handle other types of clicks

* Use named arguments

Signed-off-by: benjamin hoffman <[email protected]>

* Document new component <OutboundLink> (#4787)

* Add OutBoundLink component to gatsby-plugin-google-analytics

* Track outbound links on gatsbyjs.org

* Fix link errors + handle other types of clicks

* Use named arguments

* Document new component <OutboundLink>

Signed-off-by: benjamin hoffman <[email protected]>

* Publish

 - [email protected]

Signed-off-by: benjamin hoffman <[email protected]>

* Add banner for Gatsby workshops (#4788)

* Add banner for Gatsby workshops

* Copy edit

Signed-off-by: benjamin hoffman <[email protected]>

* Publish

 - [email protected]

Signed-off-by: benjamin hoffman <[email protected]>

* Update gatsby-starters.md (#4798)

Added a new starter - Gatsby Starter Business
Signed-off-by: benjamin hoffman <[email protected]>

* Add Photon to starters (#4781)


Signed-off-by: benjamin hoffman <[email protected]>

* Don't query for unnecessary fields in gatsby-node.js createPages so people don't think these are needed (#4801)


Signed-off-by: benjamin hoffman <[email protected]>

* Remove unnecessary fourth backtick (#4796)


Signed-off-by: benjamin hoffman <[email protected]>

* Fix typo (#4794)

Fix very small typo on doc under GraphQL Reference section.
Signed-off-by: benjamin hoffman <[email protected]>

* readme: Add Rohit's HBTU MUN site (#4791)

* readme: Add Rohit's HBTU MUN site

* Update README.md

Signed-off-by: benjamin hoffman <[email protected]>

* Improve description and keywords for gatsby-plugin-react-helmet so more findable in plugin library (#4806)


Signed-off-by: benjamin hoffman <[email protected]>

* Publish

 - [email protected]
 - [email protected]
 - [email protected]

Signed-off-by: benjamin hoffman <[email protected]>

* Added blog post  (#4758)

* Added blog post about WordPress to Gatsby migration

* Added blog post about WordPress to Gatsby migration - canonical info and excerpt added

* Added canonical link to header of blog post pages

* Format and edits

* Manage canonical url with react-helmet so easy for a blog post to override it

Signed-off-by: benjamin hoffman <[email protected]>

* Flag to disable uglify for production builds (#4755)

* add no-uglify option to build command

* uglify js bundles based on cli arg

* fix formatting

Signed-off-by: benjamin hoffman <[email protected]>

* Publish

 - [email protected]
 - [email protected]

Signed-off-by: benjamin hoffman <[email protected]>

* Fix banner styles (#4808)


Signed-off-by: benjamin hoffman <[email protected]>

* Queue requests from createRemoteFileNode and control concurrency of requests (#4616)

* Chunk the requests to download media objects from WP.
The blog I work on has over 9,000 media objects and currently, it tries
to download them all. This PR chunks them in groups of 100, but that
setting can be increased.

* Remove prettier forrmatting from the readme

* Clean up and document create-remote-file-node
Add Better Queue for more control over processing

* Rollback changes to wp source files

* Add queue for requesting wp objects
update readme with new config option

* Revert files to master

* No longer throw an exception when an error occurs. Just resolve with
null and move on

* Remove file lock lookup for now. 200 concurrent requests is a safe
number and we can look to change this in the future

* Cosmoetic updates

* Remove console.log

Signed-off-by: benjamin hoffman <[email protected]>

* Banner positioning fix for www (#4810)

* fixes banner scrolling on www

* fix banner positioning

Signed-off-by: benjamin hoffman <[email protected]>

* Fix spelling error (#4819)

See: #4815
Signed-off-by: benjamin hoffman <[email protected]>

* responsiveResolution is depracated (#4811)

According to #2320 "responsive" is dropped in favor of resolutions.
Signed-off-by: benjamin hoffman <[email protected]>

* Publish

 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]

Signed-off-by: benjamin hoffman <[email protected]>

* Add Storybook to Websites built with Gatsby (#4824)


Signed-off-by: benjamin hoffman <[email protected]>

* Don't handle line highlights unless there's actually line highlights fixes #4802 (#4823)

* Don't handle line highlights unless there's actually line highlights fixes #4802

* Update snapshots for gatsby-remark-embed-snippet

Signed-off-by: benjamin hoffman <[email protected]>

* Publish

 - [email protected]
 - [email protected]

Signed-off-by: benjamin hoffman <[email protected]>

* Add protocol to Storybook website (#4825)

Apparently github considers websites without protocol as relative paths to the repo
Signed-off-by: benjamin hoffman <[email protected]>

* Tags to posts (#4782)

* tags

* tags for gatsbyjs.org

* add all doc tags, queries for non-kebab-case tags like Contentful still acting weird

* fix tags

* fix link from tags page

Signed-off-by: benjamin hoffman <[email protected]>

* links to plugin authoring page added and fixed (#4822)

* links to plugin authoring page fixed

Do I use html hyperlinks in the .js file? Happy to change that if needed.

* correct .js file and corrected link

* deleted packages.js~HEAD and updated link to plugin authoring

* Fix link

Signed-off-by: benjamin hoffman <[email protected]>

* [starters] Add gatsby-starter-typescript-plus (#4821)


Signed-off-by: benjamin hoffman <[email protected]>

* add local time designators for ISO 8601 format (#4813)


Signed-off-by: benjamin hoffman <[email protected]>

* Publish

 - [email protected]

Signed-off-by: benjamin hoffman <[email protected]>

* Add new example doc: GraphQL Reference/Query Variables (#4795)

* Add new example doc: GraphQL Reference/Query Variables

* Update graphql-reference.md

Signed-off-by: benjamin hoffman <[email protected]>

* Omit undefined attributes from noscript images (#4639)

* Set default noscript width and height to null

To solve issue #4317, this sets the default values of the noscript image's height and width attributes to null. The current default values of "" fail HTML validation because these attributes (if present) must be non-negative integers. Omitting these non-required attributes entirely when no width/height is provided (by setting them to null) solves the validation issue.

* Omit undefined attributes from noscriptImg string output 

This edit checks each prop sent to noscriptImg() to see if it exists before adding the relevant attribute to the `<img>` string.

This prevents attributes with undefined values from being added to the markup as empty strings (e.g. `width=""` and `height=""`), which can cause HTML validation errors in some cases.

The two required `<img>` attributes (`src` and `alt`) are included as empty strings by default. All other attributes are omitted if undefined.

* Fixed typo in comment

* Include opacity and transitionDelay prop values

I accidentally omitted the prop values for opacity and transitionDelay (I only included the default values). 

This edit adds the prop values (if any) back in.

Signed-off-by: benjamin hoffman <[email protected]>

* improve error message for graphql queries (#4615)

* improve error message for graphql queries

Show where the `.cache` file is to make debugging easier.

* improve error message for graphql queries

Show the path (slug, usually) and the pluginID

* Update query-runner.js

Signed-off-by: benjamin hoffman <[email protected]>

* Publish

 - [email protected]
 - [email protected]

Signed-off-by: benjamin hoffman <[email protected]>

* Styleguide example (#3304)

* Adds plop boilerplate

* Adds base stuff

* Configurable background colors

* Rename props

* Add a comment

* Add a component README

* Tweaks

* Can query successfully

* Adds components and index

* Add prop types

* Adds component index

* Link back to component index

* Showing props / methods

* Add size prop to Button

* Remove log

* We are querying markdown

* Feeds example html into renderer

* Parsing / rendering HTML

* Starts parsing nodes

* It works

* Add prop types

* Adds size example to README

* Sets up component index

* Writes dyanmic component index to the cache

* Renaming for clarity

* Add description

* Renaming

* Possible strategy for ensuring durability of components in library previews

* Using a particular prism theme

* Fix proptypes

* POC styling editor

* Converts to table

* new name

Signed-off-by: benjamin hoffman <[email protected]>

* Update README.md (#4829)

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

Signed-off-by: benjamin hoffman <[email protected]>

* add audacious project to showcase

Add a link to https://audaciousproject.org/, which launched today (4/4/2018)
Signed-off-by: benjamin hoffman <[email protected]>

* [gatsby-source-wordpress] Handle all media types (#4817)

* Abstract media checking to URL in normalize.js

* Format request-in-queue.js

* Format __tests__/request-in-queue.js

Signed-off-by: benjamin hoffman <[email protected]>

* add new starter (gatsby advanced blog)

Signed-off-by: benjamin hoffman <[email protected]>

* Publish

 - [email protected]
 - [email protected]

Signed-off-by: benjamin hoffman <[email protected]>

* Add missing import

Signed-off-by: benjamin hoffman <[email protected]>

* Completed instructions to use gatsby-transformer-excel (#4852)

* Completed instructions to use gatsby-transformer-excel

After trying to use the plugin for a while, I figured out that I needed to use `gatsby-source-filesystem` to point my Excel's files directory.

I propose to update the documentation in this way.

* Update README.md

Signed-off-by: benjamin hoffman <[email protected]>

* iPhone X support (#4835)

Adds support for the iPhone X safe area insets.

Link: https://webkit.org/blog/7929/designing-websites-for-iphone-x/

Here’s a preview of what it looks like: https://twitter.com/codeOfRobin/status/981473964223430658

Signed-off-by: Robin Malhotra <[email protected]>Signed-off-by: benjamin hoffman <[email protected]>

* change pathPrefix from a plugin option to passed opt (#4841)


Signed-off-by: benjamin hoffman <[email protected]>

* Updating gatsby-plugin-manifest (#4382)

* add auto image generation support, update docs

* fix spelling error and clarify wording

* Update docs with shannon's feedback

* rewrite since I forgot to save

* Update README.md

* Update gatsby-node.js

* I made some of the language consistent like shannon requested but using the "mode" idea.

made some formatting more consistent.

Fixed the Hybrid description to be more clear.
 Hybrid only gerates icons from the provided
`icons` array, not a amalgamation of both.

* Update package.json

Add some more keywords so this plugin will show up for searches for those in our plugin library.

Signed-off-by: benjamin hoffman <[email protected]>

* Publish

 - [email protected]
 - [email protected]
 - [email protected]

Signed-off-by: benjamin hoffman <[email protected]>

* Update Gatsbygram data from instagram (#4855)

* For some reason, one of the gatsbygram images is failing to transform which breaks appveyor. Quick workaround

* Or I guess I just needed to refresh the data

* Delete old file

* Add new file

Signed-off-by: benjamin hoffman <[email protected]>

* [gatsby-source-wordpress] take advantage of `modified` field in media rest endpoint to not request file if we already have it (#4872)


Signed-off-by: benjamin hoffman <[email protected]>

* Publish

 - [email protected]

Signed-off-by: benjamin hoffman <[email protected]>

* Add blog post introducing RFC process (#4876)

* Add blog post introducing RFC process

* Small fixes

* Add links to contributing docs to RFC blog post

* Add date

Signed-off-by: benjamin hoffman <[email protected]>

* [gatsby-source-filesystem/createRemoteFileNode] wait for file stream to finish, not just for response (#4877)

* format

* [gatsby-source-filesystem/createRemoteFileNode] wait for file stream to finish, not just for response

Signed-off-by: benjamin hoffman <[email protected]>

* Publish

 - [email protected]
 - [email protected]
 - [email protected]

Signed-off-by: benjamin hoffman <[email protected]>

* Correct the name of the WordPress REST API 

The WordPress REST API is officially referred to as the WP REST API. There is a JSON REST API plugin, which could be confusing to users.
Signed-off-by: benjamin hoffman <[email protected]>

* fix(gatsby-transfomer-remark): memory leak of ASTPromiseMap
Signed-off-by: benjamin hoffman <[email protected]>

* Remove redundantcy in WordPress' API name

I'm trying to be perfectly clear in the name of the API that is used. Perfect clarity includes removing redundancy and ambiguity. 

https://cl.ly/1Z2e2b0d0t1g
https://developer.wordpress.org/rest-api/
Signed-off-by: benjamin hoffman <[email protected]>

* Move default icons to common file (#4867)

Fixes #4865
Signed-off-by: benjamin hoffman <[email protected]>

* Publish

 - [email protected]
 - [email protected]

Signed-off-by: benjamin hoffman <[email protected]>

* Link Gatsbygram Case Study in README (#4879)


Signed-off-by: benjamin hoffman <[email protected]>

* Handle banner in sidebar styles fixes #4878 (#4886)


Signed-off-by: benjamin hoffman <[email protected]>

* Adds new starter "gatsby-starter-procyon" (#4871)


Signed-off-by: benjamin hoffman <[email protected]>

* Add dependency instruction (#4869)

* Add dependency instruction

When using the gatsby-transformer-javascript-frontmatter the
gatsby-source-filesystem plugin needs to be installed as well but this
is nowhere documented.

* Update README.md

Signed-off-by: benjamin hoffman <[email protected]>

* Explained what cd means for starter installation (#4737)

* Explained what cd means for starter installation

Is "change" the right word in this phrasing?

"Similar to part one, open a new terminal window and run the following commands to install and then change to your new tutorial-part-two directory:"

* made name of directory clear

* Add back ticks to directory, grammar edit

* Add back ticks to directory, grammar

Broke up the sentence and opted for “just like in” for clarity. “Similar to” makes me have to think “what is similar?” which makes me doubt myself.

* added back ticks

Thanks for this idea!

Signed-off-by: benjamin hoffman <[email protected]>

* Don't add an extra trailing newline part deux (#4831)

* Don't add an extra trailing newline part deux

When using the highlighting lines, don't add an extra trailing newline.

* update snapshots in gatsby-remark-embed-snippet

Signed-off-by: benjamin hoffman <[email protected]>

* Publish

 - [email protected]
 - [email protected]
 - [email protected]

Signed-off-by: benjamin hoffman <[email protected]>

* Add gatsby-starter-2column-portfolio starter (#4883)


Signed-off-by: benjamin hoffman <[email protected]>

* adjust indices used for extracting graphqlparser errors after adding capturing group in #4618 (#4889)


Signed-off-by: benjamin hoffman <[email protected]>

* Publish

 - [email protected]

Signed-off-by: benjamin hoffman <[email protected]>

* Formatting fix in Readme (#4897)

Within the table documenting the _`gatsby-image` props_ the notation `string|object` led to markdown interpreting the `|` as a column separation. I changed it to `string` / `object`. This way the description of these properties now also shows up.
Signed-off-by: benjamin hoffman <[email protected]>

* Relocate manifest.json to ./public/ (#4890)

* Relocate manifest.json to ./public/

* Remove unused variables

* Use path.join

Signed-off-by: benjamin hoffman <[email protected]>

* Add upGizmo to showcase (#4902)


Signed-off-by: benjamin hoffman <[email protected]>

* Publish

 - [email protected]
 - [email protected]

Signed-off-by: benjamin hoffman <[email protected]>

* Extract `getNode` method from `args`, not `boundActionCreators` (#4907)


Signed-off-by: benjamin hoffman <[email protected]>

* Publish

 - [email protected]
 - [email protected]
 - [email protected]

Signed-off-by: benjamin hoffman <[email protected]>

* feat: add airtable tutorial

Signed-off-by: Kurtis Kemple <[email protected]>
Signed-off-by: benjamin hoffman <[email protected]>

* move gatsby to automated Icon generation with new manifest plugin features (#4929)

Signed-off-by: AJ Moon <[email protected]>Signed-off-by: benjamin hoffman <[email protected]>

* update CONTRIBUTING.md with DCO section (#4924)

* update CONTRIBUTING.md with DCO section

Signed-off-by: Michal Piechowiak <[email protected]>

* Minor tweaks

Signed-off-by: Mike Allanson <[email protected]>
Signed-off-by: benjamin hoffman <[email protected]>

* Added bastionbot.org to showcase (#4909)


Signed-off-by: benjamin hoffman <[email protected]>

* Fix the version of imagemin-pngquant (#4915)

Signed-off-by: Shaun Bent <[email protected]>Signed-off-by: benjamin hoffman <[email protected]>

* Blog Post - Comments with Gatsby (#4916)


Signed-off-by: benjamin hoffman <[email protected]>

* feat: add simple auth example (#4923)

This is a demo of client-only routes that require a user to be authenticated before viewing. It does NOT show how to build secure authentication. (This is called out in the README.)

Signed-off-by: Jason Lengstorf <[email protected]>Signed-off-by: benjamin hoffman <[email protected]>

* Added createTypeName to ensure unique name for union types. (#4925)

Signed-off-by: Michael Hellein <[email protected]>Signed-off-by: benjamin hoffman <[email protected]>

* Publish

 - [email protected]
 - [email protected]
 - [email protected]

Signed-off-by: benjamin hoffman <[email protected]>

* Update building-apps-with-gatsby.md

Signed-off-by: Kyle Mathews <[email protected]>
Signed-off-by: benjamin hoffman <[email protected]>

* Fix typo

Signed-off-by: Mike Allanson <[email protected]>Signed-off-by: benjamin hoffman <[email protected]>

* add yuuniworks.com to showcase

Signed-off-by: stam <[email protected]>
Signed-off-by: benjamin hoffman <[email protected]>

* Add chinloongtan.com to showcase

Signed-off-by: chinloong <[email protected]>
Signed-off-by: benjamin hoffman <[email protected]>

* Ignore nodes with no URL field (#4930)

Signed-off-by: David Beckley <[email protected]>Signed-off-by: benjamin hoffman <[email protected]>

* Documentation for multiple environments (#4858)

* Documentation for multiple environments

Updating documentation to provide guidance on environment support beyond development and production

* add gatsby develop environment command

Signed-off-by: benjamin hoffman <[email protected]>

* chore(npm source): use index.browse (#4861)

* chore(npm source): use index.browse

This will get all of the hits, even if they are on multiple pages, and is actually better for this usecase

Signed-off-by: Haroen Viaene <[email protected]>

* chore(search): update API key with unique one for gatsby

Signed-off-by: Haroen Viaene <[email protected]>

* simplify and fix

Signed-off-by: Haroen Viaene <[email protected]>
Signed-off-by: benjamin hoffman <[email protected]>

* Grammar fixes in tutorial. (#4928)

Signed-off-by: Tim Whiteaker <[email protected]>Signed-off-by: benjamin hoffman <[email protected]>

* Changed createNode docs to show parent should be set to null instead of empty string when not needed.

Signed-off-by: Grayson Hicks <[email protected]>
Signed-off-by: benjamin hoffman <[email protected]>

* Quick fix for www

Signed-off-by: Mike Allanson <[email protected]>
Signed-off-by: benjamin hoffman <[email protected]>

* Fix link in blog post (#4959)


Signed-off-by: benjamin hoffman <[email protected]>

* Refactors email signup form to use gatsby-plugin-mailchimp

Signed-off-by: benjamin hoffman <[email protected]>

* Blog post - Trying out Gatsby at Work & Co (#4945)

Signed-off-by: Sarah Mogin <[email protected]>Signed-off-by: benjamin hoffman <[email protected]>

* Add F1 Vision to showcase (#4958)

Signed-off-by: Martin Bavio <[email protected]>Signed-off-by: benjamin hoffman <[email protected]>

* Small fixes to source-wordpress README

Signed-off-by: Kyle Mathews <[email protected]>
Signed-off-by: benjamin hoffman <[email protected]>

* Fix typo
Signed-off-by: benjamin hoffman <[email protected]>

* Refactors from async/await to then/catch

Signed-off-by: benjamin hoffman <[email protected]>

* Removes useless gatsby-node change

Signed-off-by: benjamin hoffman <[email protected]>

* Bumps dep version

Signed-off-by: benjamin hoffman <[email protected]>

* removes useless deps
@jlengstorf
Copy link
Contributor

Hiya @dojineko! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moonmeister moonmeister moonmeister approved these changes

@KyleAMathews KyleAMathews KyleAMathews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dojineko @gatsbybot @moonmeister @KyleAMathews @jlengstorf