Refactors email signup form to use gatsby-plugin-mailchimp
#4589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Deploy preview for gatsbygram ready! Built with commit fc6f8de |
|
Deploy preview for using-drupal ready! Built with commit fc6f8de |
benjaminhoffman
changed the title
gatsby-plugin-mailchimpgatsby-plugin-mailchimp
|
@KyleAMathews I think this is ready for merging. Is there a way I can verify in a staging environment? I've been running But I'd love to test once more on a staging environment. ps - no idea how the commit history on this PR got so mangled but please squash when you merge! |
Signed-off-by: benjamin hoffman <[email protected]>
Signed-off-by: benjamin hoffman <[email protected]>
* Remove yarn from “Deploying” TODO: no sure if to remove/convert yarn example from GitLab instructions on this page, since GitLab might rely on yarn and not npm. * Use npm instead of yarn in Style Guide * Minor: guides -> Guides * npm instead of Yarn in GitHub Pages setup * GitLab yarn -> npm * Revert "Use npm instead of yarn in Style Guide" This reverts commit ac72f11. For our internal stuff, we do want people to use Yarn as we commit yarn.lock files. * Blog: Hexo yarn -> npm * Package readme: yarn -> npm Signed-off-by: benjamin hoffman <[email protected]>
* remark-prismjs: refactor tests into pre and code * remark-prismjs: add aliases for languages This allows specifying aliases for languages when using prismjs. Fixes #4549 Signed-off-by: benjamin hoffman <[email protected]>
In an attempt to debug issue #4680 and generally improve the performance of Gatsby as a whole, we swapped out the Array that `getState()` uses internally with a `Map()`. Signed-off-by: benjamin hoffman <[email protected]>
- [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] Signed-off-by: benjamin hoffman <[email protected]>
Signed-off-by: benjamin hoffman <[email protected]>
replacing hunterchang.com with CodeBushi Signed-off-by: benjamin hoffman <[email protected]>
Signed-off-by: benjamin hoffman <[email protected]>
Signed-off-by: benjamin hoffman <[email protected]>
Signed-off-by: benjamin hoffman <[email protected]>
* fix logic to determine selected plugin from list * fix selected style for scoped packages Signed-off-by: benjamin hoffman <[email protected]>
Instead of: You can now view gatsby-starter-default in the browser. It’s now: You can now view gatsbyjs.org in the browser. Signed-off-by: benjamin hoffman <[email protected]>
Signed-off-by: benjamin hoffman <[email protected]>
This is a demo of client-only routes that require a user to be authenticated before viewing. It does NOT show how to build secure authentication. (This is called out in the README.) Signed-off-by: Jason Lengstorf <[email protected]>Signed-off-by: benjamin hoffman <[email protected]>
Signed-off-by: Michael Hellein <[email protected]>Signed-off-by: benjamin hoffman <[email protected]>
- [email protected] - [email protected] - [email protected] Signed-off-by: benjamin hoffman <[email protected]>
Signed-off-by: Kyle Mathews <[email protected]> Signed-off-by: benjamin hoffman <[email protected]>
Signed-off-by: Mike Allanson <[email protected]>Signed-off-by: benjamin hoffman <[email protected]>
Signed-off-by: stam <[email protected]> Signed-off-by: benjamin hoffman <[email protected]>
Signed-off-by: David Beckley <[email protected]>Signed-off-by: benjamin hoffman <[email protected]>
* Documentation for multiple environments Updating documentation to provide guidance on environment support beyond development and production * add gatsby develop environment command Signed-off-by: benjamin hoffman <[email protected]>
* chore(npm source): use index.browse This will get all of the hits, even if they are on multiple pages, and is actually better for this usecase Signed-off-by: Haroen Viaene <[email protected]> * chore(search): update API key with unique one for gatsby Signed-off-by: Haroen Viaene <[email protected]> * simplify and fix Signed-off-by: Haroen Viaene <[email protected]> Signed-off-by: benjamin hoffman <[email protected]>
Signed-off-by: Tim Whiteaker <[email protected]>Signed-off-by: benjamin hoffman <[email protected]>
Signed-off-by: chinloong <[email protected]> Signed-off-by: benjamin hoffman <[email protected]>
…of empty string when not needed. Signed-off-by: Grayson Hicks <[email protected]> Signed-off-by: benjamin hoffman <[email protected]>
Signed-off-by: Mike Allanson <[email protected]> Signed-off-by: benjamin hoffman <[email protected]>
Signed-off-by: benjamin hoffman <[email protected]>
Signed-off-by: Sarah Mogin <[email protected]>Signed-off-by: benjamin hoffman <[email protected]>
Signed-off-by: Martin Bavio <[email protected]>Signed-off-by: benjamin hoffman <[email protected]>
Signed-off-by: Kyle Mathews <[email protected]> Signed-off-by: benjamin hoffman <[email protected]>
Signed-off-by: benjamin hoffman <[email protected]>
Signed-off-by: benjamin hoffman <[email protected]>
Signed-off-by: benjamin hoffman <[email protected]>
Signed-off-by: benjamin hoffman <[email protected]>
Signed-off-by: benjamin hoffman <[email protected]>
m-allanson
approved these changes
Apr 17, 2018
There was a problem hiding this comment.
Nice, thanks @benjaminhoffman! You can see a staging version at https://deploy-preview-4589--gatsbyjs.netlify.com/
I'm not sure what's happening with the commits either.. d'you want to try squashing them all?
|
Actually they should get squashed when this is merged. I think this is ready to merge. |
|
Thanks @benjaminhoffman! Nice refactor into a plugin 👊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the email capture form to use the brand new
gatsby-plugin-mailchimp! This plugin executes the same logic that has been refactored out of thewwwcodebase except now anyone can use it since it's a plugin!