[v2] adjust createLocation calls after #4714 #4805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
The change was intentional, but untested. The idea was that the prefix is set on the router, so the Link component doesn't need to do anything, since the router should automatically add the prefix. |
jquense
reviewed
Apr 2, 2018
packages/gatsby-link/src/index.js
Outdated
| @@ -17,6 +17,12 @@ function normalizePath(path) { | |||
| return path.replace(/^\/\//g, `/`) | |||
| } | |||
|
|
|||
| function createLocation(path, history) { | |||
| var location = cL(path, null, null, history.location) | |||
There was a problem hiding this comment.
I think the problem was i just assuming we were calling these two functions with the same arguments. but it looks like the RR createLocation has a different signature.
There was a problem hiding this comment.
yeah, it seems that this local createLocation signature is different than one imported from history, I will update this PR and instead of reverting your changes will adjust params in createLocation calls
pieh
force-pushed
the
gatsby-link-revert-4714
branch
from
fb24f19
to
cd76ee7
Compare
pieh
changed the title
|
updated this PR |
|
Thanks for looking into this @pieh! |
m-allanson
added a commit
to m-allanson/gatsby
that referenced
this pull request
Apr 4, 2018
* v2: Docgen improvements (gatsbyjs#4757) adjust createLocation calls after gatsbyjs#4714 (gatsbyjs#4805) Update breaking changes doc use basename for router instead of prefixing in link (gatsbyjs#4714) Fix inlined styles with path-prefixing (gatsbyjs#4717) Publish Upgrade & format [v2][wip] Upgrade Gatsby v2 to webpack 4 (gatsbyjs#4588) fix some jsdoc parsing bits (gatsbyjs#4675) [v2] fix wrong merge Publish Migrate to React Hot Loader v4 (gatsbyjs#4500) [v2] Fix deleteNodes deprecation (gatsbyjs#4453) Publish Switch to latest version of sharp to prevent yarn/npm errors (gatsbyjs#4417) # Conflicts: # packages/gatsby/package.json # packages/gatsby/src/utils/webpack-utils.js # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gatsby-linkchanges in #4714 broke this component for me, reverting them fixes it@jquense was those changes intentional? I can look more in depth into it, just let me know