[v2] Upgrade Gatsby v2 to webpack 4 #4588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Updated the initial comment with what's done and WIP TODOs |
* escape path for regexp because windows uses backslash * remove WatchMissingNodeModulesPlugin * remove gatsby-module-loader in favor of using import() * add layoutComponentChunkName to initial scripts * add initial styles as link tags * use stringify because it's safer * there is no ignoreOrder option * use [chunkhash] and [name] for CSS files * use oneOf rule to match only one of css and css modules * add a TODO about server rendering and CSS * use development mode in devlop build * add CSS support for develop mode * use [chunkhash] * add css inlining * Simplify less and sass rules
KyleAMathews
changed the title
|
excited to try this out! |
|
Out in [email protected]! |
m-allanson
added a commit
to m-allanson/gatsby
that referenced
this pull request
Apr 4, 2018
* v2: Docgen improvements (gatsbyjs#4757) adjust createLocation calls after gatsbyjs#4714 (gatsbyjs#4805) Update breaking changes doc use basename for router instead of prefixing in link (gatsbyjs#4714) Fix inlined styles with path-prefixing (gatsbyjs#4717) Publish Upgrade & format [v2][wip] Upgrade Gatsby v2 to webpack 4 (gatsbyjs#4588) fix some jsdoc parsing bits (gatsbyjs#4675) [v2] fix wrong merge Publish Migrate to React Hot Loader v4 (gatsbyjs#4500) [v2] Fix deleteNodes deprecation (gatsbyjs#4453) Publish Switch to latest version of sharp to prevent yarn/npm errors (gatsbyjs#4417) # Conflicts: # packages/gatsby/package.json # packages/gatsby/src/utils/webpack-utils.js # yarn.lock
mwfrost
pushed a commit
to mwfrost/gatsby
that referenced
this pull request
Apr 20, 2023
* WIP' * WIP * Upgrade packages * Use mini-css-extract-plugin instead of extract-text-webpack-plugin * Add mini-css-extract-plugin to sass/less plugins * Combine build-css with build-javascript — css modules not working atm * [v2] Webpack 4 additions (gatsbyjs#4627) * escape path for regexp because windows uses backslash * remove WatchMissingNodeModulesPlugin * remove gatsby-module-loader in favor of using import() * add layoutComponentChunkName to initial scripts * add initial styles as link tags * use stringify because it's safer * there is no ignoreOrder option * use [chunkhash] and [name] for CSS files * use oneOf rule to match only one of css and css modules * add a TODO about server rendering and CSS * use development mode in devlop build * add CSS support for develop mode * use [chunkhash] * add css inlining * Simplify less and sass rules * Add oneOf to gatsby-plugin-stylus * Add pathPrefix support for the data-href when inlining critical CSS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently JavaScript builds are going well.
SplitChunksPluginis 💯 and completely automates creating really great chunks.I'm publishing this branch as canary releases as I go so you can try this PR out by changing the version of
gatsbyand any gatsby plugins tocanary.TODOs:
build-csswithbuild-javascriptstageModule build failed: Error: Didn't get a result from child compilerfor CSS ModulesNot blocking for this PR but blocking for releasing Gatsby v2
Testing instructions:
yarn bootstrap