-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby): fix --https option for develop #36248
Conversation
key: Buffer | ||
cert: Buffer | ||
key: string | ||
cert: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are passing ICert Object to child process, so this has to be serializable. Buffer can be serialized but but this was fastest way to fix as Strings are also supported.
Without this I was getting:
The "options.cert" property must be of type string or an instance of Buffer, TypedArray, or DataView. Received an instance of Object
Any idea when this will get a release? This is broken in 4.19.0, 4.19.1 and 4.19.2. |
This issue is pretty urgent. Build is broken from 4.18 and below, and Dev is broken 4.19 |
Can we get a release with this fix in? Currently hacking this in locally with patch-package |
A minor release goes out every two weeks, so the next one is tomorrow. |
This was released in |
Description
#35675 broke https option, this change restores it
Related Issues
Fixes #36241