chore(gatsby): remove other services #35675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
wardpeet
removed
the
status: triage needed
wardpeet
force-pushed
the
chore/remove-extra-port
branch
from
1417de9
to
5a73c9b
Compare
wardpeet
force-pushed
the
chore/remove-extra-port
branch
3 times, most recently
from
d679bb3
to
774a86e
Compare
wardpeet
added
the
type: maintenance
tyhopp
reviewed
Jun 24, 2022
There was a problem hiding this comment.
Love this, re-ran the tests and it looks like the manifest one fails consistently though https://app.circleci.com/pipelines/github/gatsbyjs/gatsby/83651/workflows/e28aa383-2784-4acc-a195-c6dd7f0dfb4c/jobs/997261
wardpeet
force-pushed
the
chore/remove-extra-port
branch
3 times, most recently
from
0c1c63c
to
bb84752
Compare
pieh
reviewed
Jul 7, 2022
wardpeet
force-pushed
the
chore/remove-extra-port
branch
from
9eaf90b
to
06e5fee
Compare
LekoArts
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We used to have gatsby-admin and gatsby-desktop that leveraged these extra services we spun up. We've officially deprecated admin & desktop for a while so there is not reason to keep this around.
If we want to pursue the restart screen and such we can simply use one HTTP connection and share the socket (this is how cluster module works).