Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(www): starter is already a node #21951

Merged
merged 1 commit into from
Mar 4, 2020
Merged

fix(www): starter is already a node #21951

merged 1 commit into from
Mar 4, 2020

Conversation

pvdz
Copy link
Contributor

@pvdz pvdz commented Mar 4, 2020

The starters array used to be an array of edges and is "now" an array of nodes so accessing .node is no longer necessary. So dropping the access should make it work again.

Fixes #21942

Bug was introduced by #21792

@pvdz
fix(www): starters is already a node
14427cd 
The `starters` array used to be an array of edges and is "now" an array of nodes so accessing `.node` is no longer necessary. So dropping the access should make it work again.

Fixes #21942

Bug was introduced by #21792
@pvdz pvdz requested a review from a team as a code owner March 4, 2020 09:43
@pvdz pvdz mentioned this pull request Mar 4, 2020
Closed
sidharthachatterjee
sidharthachatterjee approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay

@sidharthachatterjee sidharthachatterjee merged commit 996ac5e into master Mar 4, 2020
@sidharthachatterjee sidharthachatterjee deleted the fix-21942 branch March 4, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidharthachatterjee sidharthachatterjee sidharthachatterjee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search on starters
2 participants
@pvdz @sidharthachatterjee