Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search on starters #21942

Closed
rathesDot opened this issue Mar 3, 2020 · 2 comments · Fixed by #21951
Closed

Search on starters #21942

rathesDot opened this issue Mar 3, 2020 · 2 comments · Fixed by #21951
Assignees
@Usamaliaquat123
Labels
type: bug An issue or pull request relating to a bug in Gatsby

Comments

@rathesDot
Copy link
Contributor

rathesDot commented Mar 3, 2020 •
edited
Loading

Description

If you go to https://www.gatsbyjs.org/starters/?v=2 and start searching (the input field for searching starters, not the main search), you will get a blank page.

Steps to reproduce

see above

Expected result

You should see filtered results based on the input value.

Actual result

Page breaks and renders nothing.

Environment

Gatsby website, the starters page.

The error message that I get is

TypeError: Cannot read property 'toLowerCase' of undefined
    at filtered-starters.js:86

which is here

gatsby/www/src/views/starter-library/filtered-starters.js

Line 86 in 5baaa0f

JSON.stringify(starter.node)

if I'm not mistaken.
@rathesDot rathesDot added the type: bug An issue or pull request relating to a bug in Gatsby label Mar 3, 2020
@Usamaliaquat123 Usamaliaquat123 self-assigned this Mar 4, 2020
@Usamaliaquat123
Copy link
Contributor

@rathesDot right I think it causes the problem with toLowerCase or includes cause its getting undefined..

@Usamaliaquat123 Usamaliaquat123 mentioned this issue Mar 4, 2020
Closed
pvdz added a commit that referenced this issue Mar 4, 2020
@pvdz
fix(www): starters is already a node
14427cd 
The `starters` array used to be an array of edges and is "now" an array of nodes so accessing `.node` is no longer necessary. So dropping the access should make it work again.

Fixes #21942

Bug was introduced by #21792
@pvdz pvdz mentioned this issue Mar 4, 2020
Merged
@pvdz
Copy link
Contributor

pvdz commented Mar 4, 2020

Thanks for reporting.

I've filed #21951 which should fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Usamaliaquat123 Usamaliaquat123

Labels
type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(www): starter is already a node gatsbyjs/gatsby
3 participants
@pvdz @rathesDot @Usamaliaquat123