Properly load options for Remark #1441
Conversation
|
Deploy preview ready! Built with commit 6fb6977 |
|
Deploy preview ready! Built with commit 6fb6977 |
|
Deploy preview ready! Built with commit 6fb6977 |
|
@benmccormick Yay! 💪 |
|
@fk I added an example. My editor killed some trailing spaces so the diff is a bit messy though. Do we care about cleaning that up, or is it good as is? |
|
Run "npm run format" from the base of the repo to clean things up
…On Sun, Jul 9, 2017, 2:47 PM Ben McCormick ***@***.***> wrote:
@fk <https://github.com/fk> I added an example. My editor killed some
trailing spaces so the diff is a bit messy though. Do we care about
cleaning that up, or is it good as is?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1441 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AYdmDY-VTBLNPBPCmVX01sKGT7sa8SUpks5sMUpvgaJpZM4OSLSH>
.
|
|
@benmccormick 👍 Thank you! Let me take a look! (@KyleAMathews is the authority here, just chimed in because I didn't want to forget adding the example :D) |
|
@benmccormick @KyleAMathews And there he is, the infamous KyleBot :) ;) |
| @@ -11,14 +11,14 @@ tags: | |||
|  | |||
| *Photo by [Joshua Earle](https://unsplash.com/@joshuaearle) via [Unsplash](https://unsplash.com/@joshuaearle?photo=-87JyMb9ZfU)* | |||
|
|
|||
| **_Note how all headlines below show an anchor link when you hover them?_** | |||
There was a problem hiding this comment.
Those two spaces at the end of a line actually do a <br>, so it'd be nice if you could turn off "trim end of line whitespace" in your editor real quick :/.
Quoting from the Markdown doc:
When you do want to insert a
<br />break tag using Markdown, you end a line with two or more spaces, then type return.
There was a problem hiding this comment.
Huh, I've been writing Markdown for years and never knew that. sigh, will fix.
There was a problem hiding this comment.
;) Sorry :( … Looking at using-remark, I think I tend to overuse that feature by now –
maybe to make up for all the times that my editor settings ate them up when editing other peoples docs? :)
FWIW, I started using Atom last year and its whitespace package takes care of that issue nicely.
| @@ -133,8 +133,8 @@ In this example, leading and trailing spaces are shown with with dots: ⋅ | |||
|
|
|||
| You can have properly indented paragraphs within list items. Notice the blank line above, and the leading spaces (at least one, but we'll use three here to also align the raw Markdown). | |||
|
|
|||
| To have a line break without a paragraph, you will need to use two trailing spaces. | |||
There was a problem hiding this comment.
Ah, there even is an example for the two space stuff – totally forgot abt that already :)
| [Blockquotes](#blockquotes) | ||
| [Inline HTML](#html) | ||
| [Horizontal Rule](#hr) | ||
| [Line Breaks](#lines) |
There was a problem hiding this comment.
Could you link to the new "Footnotes" section here?
Fixes gatsbyjs#1434 Remark now loads options with a `data` method instead of directly in the constructor.
|
Deploy preview failed. Built with commit 6fb6977 https://app.netlify.com/sites/using-styled-components/deploys/5962ac75424ef245f59b2fcd |
|
@fk @KyleAMathews comments should be addressed. I'm not sure what is going on with the failing deploys though, I can't see any of the netlify logs. |
|
The netlify error was a random yarn install failure so 🤷♂️ But using-remark built correctly and we have footnotes! https://deploy-preview-1441--using-remark.netlify.com/hello-world-kitchen-sink/#fnref-1 |
|
thanks for researching the fix and adding the PR! |
Fixes #1434
Remark now loads options with a
datamethod instead of directly in the constructor.This change isn't really well documented right now, but you can see the details in this issue.