Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footnotes aren't rendering in Markdown #1434

Closed
benmccormick opened this issue Jul 9, 2017 · 4 comments
Closed

Footnotes aren't rendering in Markdown #1434

benmccormick opened this issue Jul 9, 2017 · 4 comments

Comments

@benmccormick
Copy link
Contributor

It looks like gatsby is intending to render footnotes when parsing Markdown, based on the plugin code. Unfortunately this isn't happening in practice.

I'm seeing this behavior on my site. This post for example is based on this source. You can scroll down and see that the footnote isn't being formatted.

I was able to verify the behavior outside of my environment by cloning https://github.com/KyleAMathews/blog and adding a footnote to a post. It also didn't format. I also disabled all of the remark-plugins my blog was using, and didn't see any difference. I'm going to try to look into this, but would appreciate help if this is simple for someone else, since I've never done anything with remark and don't have a lot of context.

Minimal test case I'd expect to work, but isn't:

Test [^1].

[^1]: Testing

should be formatted to footnote html that links the references.

@KyleAMathews
Copy link
Contributor

Hmm I'm not sure why that doesn't work... things to check are what the markdown AST looks like for a very simple post and if in the html conversion process if footnotes need to be enabled there as well.

@KyleAMathews
Copy link
Contributor

Possibly one of the gatsby remark plugins is interfering with the conversion as well so you could try disabling them.

@fk
Copy link
Contributor

fk commented Jul 9, 2017

Damn, had testing and documenting footnotes on my list when setting up https://using-remark.gatsbyjs.org/ … and then forgot about it! Thanks for bringing this up @benmccormick!

@benmccormick
Copy link
Contributor Author

benmccormick commented Jul 9, 2017

@fk @KyleAMathews Turns out that remark changed the way they load options recently. Updating to the new style fixes the issue. See #1441

benmccormick added a commit to benmccormick/gatsby that referenced this issue Jul 9, 2017
Fixes gatsbyjs#1434

Remark now loads options with a `data` method instead of directly in the constructor.
KyleAMathews pushed a commit that referenced this issue Jul 9, 2017
Fixes #1434

Remark now loads options with a `data` method instead of directly in the constructor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants