-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(starter-library): add example to starter library #10425
docs(starter-library): add example to starter library #10425
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thank you for sharing your starter. I left a few comments you need to address 👍
Co-Authored-By: robertcoopercode <[email protected]>
Co-Authored-By: robertcoopercode <[email protected]>
Co-Authored-By: robertcoopercode <[email protected]>
Co-Authored-By: robertcoopercode <[email protected]>
Thanks for the quick review @LekoArts. I've updated the PR with your suggested changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
* master: (33 commits) fix(blog): youfit case study typofix Doc improvements to Visual testing with Storybook guide (gatsbyjs#10436) fix(gatsby-plugin-offline): prevent incorrect revisioning of static file by workbox (gatsbyjs#10416) fix(starters): ttag repo link fix typo in pull request template (gatsbyjs#10454) fix(www) Fix query for plugin links always ?=undefined (gatsbyjs#10453) chore(release): Publish fix(gatsby): fix extracting StaticQuery nested in shorthand fragment (gatsbyjs#10443) fix(www): avoid querying for no-cache=1 (gatsbyjs#10389) fix(gatsby-image): update typescript definitions - properly mark fields as optional (gatsbyjs#10419) refactor(gatsby): improve EnsureResources (gatsbyjs#10224) Fixed minor Typos and grammatical errors (gatsbyjs#9353) docs: add ClinciJS website into showcase (gatsbyjs#10437) docs(babel-preset-gatsby): document --save-dev flag in README (gatsbyjs#10434) fix(docs): Environment Variables Examples (gatsbyjs#10406) chore(release): Publish [gatsby-image] re: fade out base64 on full image load (gatsbyjs#7539) docs(starter-library): add example to starter library (gatsbyjs#10425) docs(gatsby-plugin-offline): specify to not HTTP-cache sw.js (gatsbyjs#10430) fix(docs): prompt => confirm (gatsbyjs#10431) ...
* docs(starter-library): add example to starter library * docs: update Netlify CMS spelling Co-Authored-By: robertcoopercode <[email protected]> * docs: rename Sass tag Co-Authored-By: robertcoopercode <[email protected]> * docs: remove 'responsive' tag Co-Authored-By: robertcoopercode <[email protected]> * docs: remove 'Gatsby V2' tag Co-Authored-By: robertcoopercode <[email protected]>
Adding an example the the Gatsby starter library 📝