Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-image): TypeScript - Mark more props as optional #10419

Merged
merged 1 commit into from
Dec 12, 2018
Merged

fix(gatsby-image): TypeScript - Mark more props as optional #10419

merged 1 commit into from
Dec 12, 2018

Conversation

jul-sh
Copy link
Contributor

@jul-sh jul-sh commented Dec 11, 2018 •
edited
Loading

It seems like these should not be a mandatory. At the moment when building a TypeScript gatsby site, TypeScript forces the user to pass a value.

@jul-sh jul-sh changed the title Gatsby-Image TypeScipt: Make placeholderStyle prop optional Gatsby-Image TypeScript: Make placeholderStyle prop optional Dec 11, 2018
@pieh
Copy link
Contributor

pieh commented Dec 11, 2018

It makes sense - could you also update

gatsby/packages/gatsby-image/index.d.ts

Lines 19 to 22 in 9c14935

base64: string
tracedSVG: string
srcWebp: string
srcSetWebp: string
to be optional? (same as in FixedObject)

@pieh pieh changed the title Gatsby-Image TypeScript: Make placeholderStyle prop optional fix(gatsby-image): TypeScript: Make placeholderStyle prop optional Dec 11, 2018
@jul-sh jul-sh changed the title fix(gatsby-image): TypeScript: Make placeholderStyle prop optional fix(gatsby-image): TypeScript - Mark more props as optional Dec 12, 2018
@jul-sh
Copy link
Contributor Author

jul-sh commented Dec 12, 2018

@pieh Excellent point, updated :)

pieh
pieh approved these changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @juliettepretot!

@pieh pieh merged commit f2b1821 into gatsbyjs:master Dec 12, 2018
@gatsbot
Copy link

gatsbot bot commented Dec 12, 2018

Holy buckets, @juliettepretot — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

m-allanson added a commit to Bouncey/gatsby that referenced this pull request Dec 14, 2018
@m-allanson
Merge branch 'master' into feat/no-watch-on-build
18f60c2 
* master: (33 commits)
  fix(blog): youfit case study typofix
  Doc improvements to Visual testing with Storybook guide (gatsbyjs#10436)
  fix(gatsby-plugin-offline): prevent incorrect revisioning of static file by workbox (gatsbyjs#10416)
  fix(starters): ttag repo link
  fix typo in pull request template (gatsbyjs#10454)
  fix(www) Fix query for plugin links always ?=undefined (gatsbyjs#10453)
  chore(release): Publish
  fix(gatsby): fix extracting StaticQuery nested in shorthand fragment (gatsbyjs#10443)
  fix(www): avoid querying for no-cache=1 (gatsbyjs#10389)
  fix(gatsby-image): update typescript definitions - properly mark fields as optional (gatsbyjs#10419)
  refactor(gatsby): improve EnsureResources (gatsbyjs#10224)
  Fixed minor Typos and grammatical errors (gatsbyjs#9353)
  docs: add ClinciJS website into showcase (gatsbyjs#10437)
  docs(babel-preset-gatsby): document --save-dev flag in README (gatsbyjs#10434)
  fix(docs): Environment Variables Examples (gatsbyjs#10406)
  chore(release): Publish
  [gatsby-image] re: fade out base64 on full image load (gatsbyjs#7539)
  docs(starter-library): add example to starter library (gatsbyjs#10425)
  docs(gatsby-plugin-offline): specify to not HTTP-cache sw.js (gatsbyjs#10430)
  fix(docs): prompt => confirm (gatsbyjs#10431)
  ...
m-allanson added a commit to lipis/gatsby that referenced this pull request Dec 17, 2018
@m-allanson
Merge branch 'master' into svgo
55f39a7 
* master: (1037 commits)
  Update starters.yml (gatsbyjs#10505)
  chore(release): Publish
  fix(graphql-skip-limit): fix hasNextPage (gatsbyjs#10504)
  chore: use cjs instead of esm for consistency (gatsbyjs#10494)
  feat(gatsby-remark-copy-linked-files): add support for video elements with `src` attribute (gatsbyjs#10395)
  typofix (gatsbyjs#10488)
  Add kobit.in to showcase (gatsbyjs#10496)
  fix(docs): window.reload => window.location.reload (gatsbyjs#10459)
  feat(www): add unbird feedback component to starter lib (gatsbyjs#10450)
  fix(blog): youfit case study typofix
  Doc improvements to Visual testing with Storybook guide (gatsbyjs#10436)
  fix(gatsby-plugin-offline): prevent incorrect revisioning of static file by workbox (gatsbyjs#10416)
  fix(starters): ttag repo link
  fix typo in pull request template (gatsbyjs#10454)
  fix(www) Fix query for plugin links always ?=undefined (gatsbyjs#10453)
  chore(release): Publish
  fix(gatsby): fix extracting StaticQuery nested in shorthand fragment (gatsbyjs#10443)
  fix(www): avoid querying for no-cache=1 (gatsbyjs#10389)
  fix(gatsby-image): update typescript definitions - properly mark fields as optional (gatsbyjs#10419)
  refactor(gatsby): improve EnsureResources (gatsbyjs#10224)
  ...
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
@jul-sh @gpetrioli
fix(gatsby-image): update typescript definitions - properly mark fiel…
1f10791 
…ds as optional (gatsbyjs#10419)

It seems like these should not be a mandatory. At the moment when building a TypeScript gatsby site, TypeScript forces the user to pass a value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jul-sh @pieh