Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more social media icons and corrections #68

Merged
merged 2 commits into from
Dec 15, 2020

Conversation

snehaM2210
Copy link

Description

I've added more social media icons like Gmail and Bitbucket and have changed the body size to fit the icons properly. I've changed the color of each icon according to the most appropriate official color code. I've also changed the listing of accounts in edit.html according to the icons listing in popup.html.
Fixes #18 (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I've tested this after each and every change and it's working perfectly well.

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

profile

profileLauncher

I've added more social media icons like gmail and bitbucket and have changed the body size to fit the icons properly.I've also changes the listing of accounts in edit.html according to the icons listing in popup.html.
@snehaM2210
Copy link
Author

Mam, Please review and merge my PR @garimasingh128 .

@snehaM2210
Copy link
Author

@garimasingh128 Hope you liked the icon changes mam, please merge it😊🤗.

@garimasingh128
Copy link
Owner

Looks good!

@garimasingh128 garimasingh128 merged commit d33664d into garimasingh128:develop Dec 15, 2020
@snehaM2210
Copy link
Author

Looks good!

Thank you Mam❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants