Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added social media icons and corrections #55

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Added social media icons and corrections #55

wants to merge 2 commits into from

Conversation

snehaM2210
Copy link

@snehaM2210 snehaM2210 commented Dec 3, 2020

Description

I have changed color of icons almost similar to their official color code and have added some other social media icons of gmail and bitbucket. I have also changed the padding of instagram icon and have listed the accounts according to the icons in edit.html. I have also changed the width of body in popup.html so that all icons fit properly.
Hope you like it and merge it!
(As in last PR , I created to merge it into master by mistake, so this time doing pull req to merge it in develop branch)

Fixes #18 (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

chrome_ext

@garimasingh128
Copy link
Owner

garimasingh128 commented Dec 6, 2020

  • content and changes looks fine but I would advice you to double check for minor errors if any.
Conflicting files
edit.html
popup.html

resolve these

@snehaM2210
Copy link
Author

Yeah sure.. I'll check the conflicts and resolve them.

@snehaM2210
Copy link
Author

I've resolved the conflicts and have also modified the extension in #68 . Hope you like it and merge it!

@garimasingh128
Copy link
Owner

Conflicting files
edit.html
popup.html

Resolve them and send me the link to your PR at [email protected] after you do so.

@garimasingh128
Copy link
Owner

Please do this asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants