Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove secrets queue and secretSynced MCM usage #780

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Remove secrets queue and secretSynced MCM usage #780

merged 2 commits into from
Feb 14, 2023

Conversation

elankath
Copy link
Contributor

@elankath elankath commented Feb 13, 2023 •
edited by himanshu-kun
Loading

What this PR does / why we need it:
Fix for make start bug where secrets hasSynced function was nil

Which issue(s) this PR fixes:
#622

Special notes for your reviewer:
Bug fix where a change was missed.

Release note:

NONE

@elankath elankath requested a review from a team as a code owner February 13, 2023 07:15
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Feb 13, 2023
@gardener-robot-ci-3
Copy link
Contributor

Thank you @elankath for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

@himanshu-kun himanshu-kun self-assigned this Feb 13, 2023
@himanshu-kun himanshu-kun added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 13, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 13, 2023
@himanshu-kun himanshu-kun added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 14, 2023
@elankath elankath removed the needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 14, 2023
@himanshu-kun himanshu-kun changed the title remove secrets queue and secretSynced MCM usage Remove secrets queue and secretSynced MCM usage Feb 14, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 14, 2023
himanshu-kun
himanshu-kun approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Feb 14, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 14, 2023
@himanshu-kun himanshu-kun merged commit f9558dd into gardener:master Feb 14, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Feb 14, 2023
@himanshu-kun himanshu-kun added this to the v0.49 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himanshu-kun himanshu-kun himanshu-kun approved these changes

Assignees

@himanshu-kun himanshu-kun

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.49
Development

Successfully merging this pull request may close these issues.
5 participants
@elankath @gardener-robot-ci-3 @himanshu-kun @gardener-robot-ci-2 @gardener-robot