Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated in-tree code #622

Closed
3 tasks done
prashanth26 opened this issue Jun 14, 2021 · 3 comments · Fixed by #769
Closed
3 tasks done

Remove deprecated in-tree code #622

prashanth26 opened this issue Jun 14, 2021 · 3 comments · Fixed by #769
Assignees
@AxiomSamarth
Labels
area/dev-productivity Developer productivity related (how to improve development) effort/1w Effort for issue is around 1 week kind/cleanup Something that is not needed anymore and can be cleaned up priority/3 Priority (lower number equals higher priority) status/closed Issue is closed (either delivered or triaged)
Milestone
2022-Q1

Comments

@prashanth26
Copy link
Contributor

prashanth26 commented Jun 14, 2021 •
edited by himanshu-kun
Loading

How to categorize this issue?

/area dev-productivity
/kind cleanup
/priority 3

What would you like to be added:
Get rid of all deprecated in-tree machine controller code

  • Unused CRDS and API objects
  • Deprecated controller code
  • Unused metrics

Why is this needed:
To get rid of os unused code.
Depends on completion of #211 to remove unused metrics and expose it elsewhere.
@prashanth26 prashanth26 added the kind/enhancement Enhancement, improvement, extension label Jun 14, 2021
@gardener-robot gardener-robot added area/dev-productivity Developer productivity related (how to improve development) kind/cleanup Something that is not needed anymore and can be cleaned up priority/3 Priority (lower number equals higher priority) labels Jun 14, 2021
@prashanth26 prashanth26 mentioned this issue Jun 14, 2021
Closed
@prashanth26 prashanth26 added this to the 2022-Q1 milestone Jul 21, 2021
@prashanth26 prashanth26 added effort/1w Effort for issue is around 1 week priority/4 Priority (lower number equals higher priority) and removed kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority) labels Jul 21, 2021
@AxiomSamarth AxiomSamarth self-assigned this Nov 2, 2021
@AxiomSamarth
Copy link
Contributor

@dkistner There is MCM In-Tree code which we would like to deprecate. As the MCM Out of Tree for all providers are available today. I want to understand the process followed in Gardener to deprecate any such dead/debt code?

@AxiomSamarth AxiomSamarth mentioned this issue Nov 9, 2021
Closed
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label May 2, 2022
@himanshu-kun himanshu-kun mentioned this issue May 25, 2022
Open
49 tasks
@elankath
Copy link
Contributor

elankath commented Oct 19, 2022 •
edited
Loading

Commencing this. (will update)

@elankath elankath mentioned this issue Jan 19, 2023
Merged
@elankath elankath mentioned this issue Feb 13, 2023
Merged
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/4 Priority (lower number equals higher priority) labels Feb 20, 2023
@himanshu-kun himanshu-kun linked a pull request Feb 20, 2023 that will close this issue
Dead Code Removal https://github.com/gardener/machine-controller-man… #769
Merged
@himanshu-kun
Copy link
Contributor

/close
Done with #769

@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AxiomSamarth AxiomSamarth

Labels
area/dev-productivity Developer productivity related (how to improve development) effort/1w Effort for issue is around 1 week kind/cleanup Something that is not needed anymore and can be cleaned up priority/3 Priority (lower number equals higher priority) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
2022-Q1
5 participants
@elankath @AxiomSamarth @prashanth26 @gardener-robot @himanshu-kun