-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dead Code Removal https://github.com/gardener/machine-controller-man… #769
Conversation
…ated modification
…s field as non-deprecated. Removed un-used code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the changes requested, kindly also remove the in-tree documentation related to how to deploy MCM
The following changes should also be done:
Other files related to doc need to be removed :
- Delete Kubenetes/secrets and docs referencing it
- Delete Kubernetes/deployment/in-tree and docs referencing it
- Sample machine object should be updated here https://github.com/elankath/machine-controller-manager/blob/e6a1bd8a076edc94e3f3891dedcdd7dd8e754199/kubernetes/machine_objects/machine.yaml#L12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also pls remove the deprecated files from this file here https://github.com/elankath/machine-controller-manager/blob/ff4c295bdc2b1a2131b075795309e6f20900108a/kubernetes/deployment/out-of-tree/deployment.yaml#L24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Dead Code Removal #622
This commit removes dead and deprecated code from the machine controller manager.
What this PR does / why we need it:
This commit removes dead and deprecated code from the machine controller manager. The machine controller is now launched by individual providers and not by the main MCM. Old Migration code from old provider specific machine classes to harmonized machine class has also been removed..
pkg/apis/machine/types.go
and api clients regenerated usingmake generate
kubernetes/crds
kubernetes/machine_classes
pkg/util/provider/drain/drain.go
which is invoked by platform specific providers.Which issue(s) this PR fixes:
#622
Special notes for your reviewer:
This change breaks compilation in individual provider repos which need to be updated. Removal of Driver.GenerateMachineClassForMigration needs to be conveyed to other stakeholders.
Release note: