-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci:component:github.com/gardener/machine-controller-manager:v0.51.1->v0.52.0] #128
Conversation
from v0.51.1 to v0.52.0
@gardener-robot-ci-1 Thank you for your contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor change needed
@@ -18,7 +19,7 @@ declare CONTROL_KUBECONFIG=${SOURCE_PATH}/dev/control_kubeconfig.yaml | |||
declare TARGET_KUBECONFIG=${SOURCE_PATH}/dev/target_kubeconfig.yaml | |||
declare TEST_SHOOT=az-ci-it | |||
declare TEST_CREDS_SECRET=test-mc-secret | |||
declare TARGET_RESOURCE_GROUP="shoot--mcm-ci--$TEST_SHOOT" | |||
declare TARGET_CLUSTER_NAME="shoot--mcm-ci--$TEST_SHOOT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it still exports TARGET_RESOURCE_GROUP
. change it to TARGET_CLUSTER_NAME
and pipeline will pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I saw this too. this script is a mess. It could use the set +o allexport
to avoid hunting for stuff like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Release Notes: