Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of go-git from Integration Tests #890

Closed
6 tasks done
elankath opened this issue Jan 4, 2024 · 0 comments
Closed
6 tasks done

Remove use of go-git from Integration Tests #890

elankath opened this issue Jan 4, 2024 · 0 comments
Assignees
@elankath
Labels
area/security Security related kind/cleanup Something that is not needed anymore and can be cleaned up kind/enhancement Enhancement, improvement, extension priority/2 Priority (lower number equals higher priority) status/closed Issue is closed (either delivered or triaged)

Comments

@elankath
Copy link
Contributor

elankath commented Jan 4, 2024 •
edited by rishabh-11
Loading

How to categorize this issue?

/area security
/kind cleanup
/priority 2

What would you like to be added:
Remove use of go-git from IT code and its vendoring.

Why is this needed:
dependabot has bumped up go-git versions due to a security ticket which is causing alerts due to PGP key data in vendored tests. Since go-git is not a prime component of MCM and is only used to clone the repo in MCM tests, we can get rid of its use and vendoring. Use the git CLI to clone the MCM repo.
@elankath elankath added the kind/enhancement Enhancement, improvement, extension label Jan 4, 2024
@gardener-robot gardener-robot added area/security Security related kind/cleanup Something that is not needed anymore and can be cleaned up priority/2 Priority (lower number equals higher priority) labels Jan 4, 2024
@elankath elankath self-assigned this Jan 4, 2024
@elankath elankath mentioned this issue Jan 4, 2024
Closed
This was referenced Jan 22, 2024
Merged
Closed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elankath elankath

Labels
area/security Security related kind/cleanup Something that is not needed anymore and can be cleaned up kind/enhancement Enhancement, improvement, extension priority/2 Priority (lower number equals higher priority) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removal of git-go from MCM Integration Tests
security fix: removal of go-git
3 participants
@elankath @gardener-robot @rishabh-11