Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keychain ignores missing secrets #44

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Keychain ignores missing secrets #44

merged 3 commits into from
Oct 18, 2023

Conversation

vpnachev
Copy link
Member

What this PR does / why we need it:
Keychain ignores missing secrets

Which issue(s) this PR fixes:
Fixes #43

Special notes for your reviewer:

Release note:

Lakom admission webhooks now ignore the image pull secrets that does not exist in the cluster.

@vpnachev vpnachev requested a review from a team as a code owner October 17, 2023 14:23
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 17, 2023
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Oct 17, 2023
dimityrmirchev
dimityrmirchev approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@dimityrmirchev dimityrmirchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Oct 18, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 18, 2023
@vpnachev vpnachev merged commit 13e98b1 into gardener:main Oct 18, 2023
1 check passed
@vpnachev vpnachev deleted the enh/keychain-ignore-missing-secrets branch October 18, 2023 09:34
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimityrmirchev dimityrmirchev dimityrmirchev approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keychain to ignore non-existing secrets
4 participants
@vpnachev @dimityrmirchev @gardener-robot-ci-1 @gardener-robot