Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keychain to ignore non-existing secrets #43

Closed
vpnachev opened this issue Oct 17, 2023 · 0 comments · Fixed by #44
Closed

Keychain to ignore non-existing secrets #43

vpnachev opened this issue Oct 17, 2023 · 0 comments · Fixed by #44
Labels
kind/enhancement Enhancement, improvement, extension status/closed Issue is closed (either delivered or triaged)

Comments

@vpnachev
Copy link
Member

What would you like to be added:
Sometimes, the pods refer to image pull secrets that simply do not exist, the image tag resolver and signature verifiers can simply ignore those secrets and work only with the available ones.

The code that needs to be changed is

if err := h.reader.Get(ctx, secretKey, secret); err != nil {
return nil, err
}
and
if err := h.reader.Get(ctx, secretKey, secret); err != nil {
return nil, err
}

Why is this needed:
To not fail when non-existing image pull secrets are set in the pods spec.

@vpnachev vpnachev added the kind/enhancement Enhancement, improvement, extension label Oct 17, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants