Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Shoots with Kubernetes version < 1.22 #23

Merged
merged 6 commits into from
Jul 20, 2023
Merged

Drop support for Shoots with Kubernetes version < 1.22 #23

merged 6 commits into from
Jul 20, 2023

Conversation

shafeeqes
Copy link
Contributor

How to categorize this PR?

/kind cleanup

What this PR does / why we need it:
Drop support for kubernetes < 1.22 for shoot-lakom-service extension.

Which issue(s) this PR fixes:
Part of gardener/gardener#7405

Special notes for your reviewer:
This PR depends on #22 , hence in draft.
/hold
/squash

Release note:

`extension-shoot-lakom-service` no longer supports Shoots with Кubernetes version < 1.22.

@gardener-robot gardener-robot added kind/cleanup Something that is not needed anymore and can be cleaned up merge/squash Should be merged via 'Squash and merge' reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Jul 3, 2023
@shafeeqes shafeeqes mentioned this pull request Jul 3, 2023
Closed
26 tasks
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 3, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 3, 2023
@vpnachev
Copy link
Member

vpnachev commented Jul 5, 2023

#19 drops/changes some of the code touched in this PR, so it should be merged later.

@vpnachev
Copy link
Member

Hello @shafeeqes, #19 is now merged so you can rebase this PR.

@shafeeqes shafeeqes marked this pull request as ready for review July 19, 2023 09:09
@shafeeqes shafeeqes requested a review from a team as a code owner July 19, 2023 09:09
@gardener-robot gardener-robot added the size/s Size of pull request is small (see gardener-robot robot/bots/size.py) label Jul 19, 2023
@shafeeqes
Copy link
Contributor Author

Hello @shafeeqes, #19 is now merged so you can rebase this PR.

Done, PTAL!

@gardener-robot gardener-robot removed the size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) label Jul 19, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 19, 2023
@shafeeqes
Copy link
Contributor Author

/unhold

@gardener-robot gardener-robot removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Jul 19, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 19, 2023
vpnachev
vpnachev requested changes Jul 19, 2023
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Just some minor nits.

pkg/lakom/resolvetag/admission.go Outdated Show resolved Hide resolved
pkg/lakom/resolvetag/admission.go Outdated Show resolved Hide resolved
pkg/lakom/verifysignature/admission.go Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Jul 19, 2023
@vpnachev vpnachev mentioned this pull request Jul 19, 2023
Merged
@shafeeqes shafeeqes requested a review from vpnachev July 20, 2023 04:30
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 20, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 20, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 20, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 20, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 20, 2023
vpnachev
vpnachev approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review labels Jul 20, 2023
@vpnachev vpnachev merged commit 1653036 into gardener:main Jul 20, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 20, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpnachev vpnachev vpnachev approved these changes

Assignees
No one assigned
Labels
kind/cleanup Something that is not needed anymore and can be cleaned up merge/squash Should be merged via 'Squash and merge' needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shafeeqes @vpnachev @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot