Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap seed with standalone installation of lakom admission controller #19

Merged
merged 25 commits into from
Jul 19, 2023
Merged

Bootstrap seed with standalone installation of lakom admission controller #19

merged 25 commits into from
Jul 19, 2023

Conversation

vpnachev
Copy link
Member

@vpnachev vpnachev commented Jun 6, 2023 •
edited
Loading

What this PR does / why we need it:
Bootstrap seed with standalone installation of lakom admission controller

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
Merge after #18

Release note:

The seed bootstrap controller is now installing a stand-alone instance of the `lakom` admission controller in the `kube-system` namespace of the seed cluster instead of running inside the extension controller manager. This is done to avoid dead locks with other admission controllers, like the `gardener-resource-manager` that targets the pods in the extensions namespaces.

@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Jun 6, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 6, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 6, 2023
@vpnachev vpnachev force-pushed the enh/bootstrap-seed-with-standalone-installation-of-lakom-admission branch from b8e2c95 to 237a75e Compare June 7, 2023 06:43
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 7, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 7, 2023
@vpnachev vpnachev force-pushed the enh/bootstrap-seed-with-standalone-installation-of-lakom-admission branch from 237a75e to f5517c6 Compare June 7, 2023 12:20
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 7, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 7, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 7, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 12, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 12, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 12, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 12, 2023
@vpnachev
Copy link
Member Author

/ready

@gardener-robot gardener-robot marked this pull request as ready for review June 12, 2023 16:32
@gardener-robot gardener-robot requested a review from a team as a code owner June 12, 2023 16:32
@gardener-robot gardener-robot added the kind/api-change API change with impact on API users label Jun 28, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 28, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 28, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 28, 2023
vpnachev added 18 commits July 18, 2023 13:44
@vpnachev
Fix network policy service annotations
6049fbe
@vpnachev
Delete the unneeded webhook secrets from the extension namespace
07d5dcf
@vpnachev
Run make revendor
053d6c1
@vpnachev
Rename seed resources
26191fb
@vpnachev
Configure extension controller service
cfe869f
@vpnachev
Remove monitoring configmap
71b60d8
@vpnachev
Add start and end of namespace reconciliaiton
b57a961
@vpnachev
Re-add health and readiness checkers
9b8a170
@vpnachev
Remove seed k8s version from reconciler
a127893 
With gardener/gardener#8087 clusters with k8s
version <= 1.21 are not supported, hence there is no need different API
versions for PDBs to be used.
@vpnachev
Read kube-system namespace on reconciliaiton
52e547f
@vpnachev
Expose owner namespace in configuraiton file, do not reuse leader ele…
f863d5f 
…ction ns
@vpnachev
Set ownerReference to the secrets in kube-system namespace
3bd86eb
@vpnachev
Set explicitly validity of the ca and server certificates
9a77811
@vpnachev
Explicitly request the CABundle secret from secretsmanager
5fa0169
@vpnachev
Change the default seedBootstrap.ownerNamespace to 'lakom-extension' …
a897b61 
…in example config
@vpnachev
Fix finding of the linter
6a817eb
@vpnachev
Address review comments
a41cbc8
@vpnachev
Configure certificate signing, rotation and retention
30b0e37
@vpnachev vpnachev force-pushed the enh/bootstrap-seed-with-standalone-installation-of-lakom-admission branch from 26ab3d2 to 30b0e37 Compare July 18, 2023 16:01
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 18, 2023
@vpnachev vpnachev requested a review from dimityrmirchev July 18, 2023 16:02
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 18, 2023
dimityrmirchev
dimityrmirchev approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@dimityrmirchev dimityrmirchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Jul 19, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 19, 2023
@vpnachev vpnachev merged commit 5de099d into gardener:main Jul 19, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 19, 2023
@vpnachev vpnachev deleted the enh/bootstrap-seed-with-standalone-installation-of-lakom-admission branch July 19, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimityrmirchev dimityrmirchev dimityrmirchev approved these changes

Assignees
No one assigned
Labels
kind/api-change API change with impact on API users needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vpnachev @gardener-robot @dimityrmirchev @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3