Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up deprecated network policy annotations and kube-apiserver webhook #18

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Clean-up deprecated network policy annotations and kube-apiserver webhook #18

merged 1 commit into from
Jun 7, 2023

Conversation

vpnachev
Copy link
Member

@vpnachev vpnachev commented Jun 5, 2023 •
edited
Loading

What this PR does / why we need it:
Clean-up deprecated network policy annotations and kube-apiserver webhook

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
Since gardener/gardener#7907 (available in gardener >= v1.71) the deprecated annotations and kube-apiserver are not

Release note:

The deprecated network policy annotations and kube-apiserver deployment webhook have been removed, thus this extension is not compatible with `gardener<v1.71.0`.
- ⚠️ make sure gardener is updated to version v1.71.0 or newer before to install this version of the extension.

@vpnachev vpnachev requested a review from a team as a code owner June 5, 2023 14:56
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jun 5, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 5, 2023
@vpnachev vpnachev mentioned this pull request Jun 6, 2023
Merged
dimityrmirchev
dimityrmirchev approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@dimityrmirchev dimityrmirchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jun 7, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 7, 2023
@vpnachev vpnachev merged commit 0ba1119 into gardener:main Jun 7, 2023
@vpnachev vpnachev deleted the clean-up/remove-deprecated-netpol-annotations-and-webhook branch June 7, 2023 07:20
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimityrmirchev dimityrmirchev dimityrmirchev approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vpnachev @dimityrmirchev @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot