Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure record for DNSEntries are left untouched during migration #408

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Ensure record for DNSEntries are left untouched during migration #408

merged 3 commits into from
Dec 18, 2024

Conversation

MartinWeindel
Copy link
Member

How to categorize this PR?

/area control-plane-migration
/kind bug

What this PR does / why we need it:
Depending on timing of concurrent reconciliations, the DNS records have been deleted temporarily during control plane migration. The migration step is now secured by setting an ignore annotation to the DNSEntries. The restore step is secured by ensuring that all entries have been reconciled and therefore are known before the DNSOwner is activated and a zone reconciliation is triggered.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
Relies on

Release note:

Ensure record for DNSEntries are left untouched during migration.

@gardener-robot gardener-robot added area/control-plane-migration Control plane migration related kind/bug Bug needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Dec 13, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 13, 2024
@MartinWeindel
Copy link
Member Author

/hold requires new release of external-dns-management containing above mentioned PRs.

@gardener-robot gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Dec 13, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 13, 2024
@MartinWeindel MartinWeindel mentioned this pull request Dec 13, 2024
Merged
@MartinWeindel
Copy link
Member Author

cc @adenitiu

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 17, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 17, 2024
@MartinWeindel MartinWeindel marked this pull request as ready for review December 18, 2024 07:18
@MartinWeindel MartinWeindel requested review from a team as code owners December 18, 2024 07:18
@MartinWeindel
Copy link
Member Author

/unhold

@gardener-robot gardener-robot removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Dec 18, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 18, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 18, 2024
marc1404
marc1404 reviewed Dec 18, 2024
View reviewed changes
Copy link
Member

@marc1404 marc1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for improving the reliability of the migration process!
I have a small naming related suggestion but otherwise all good :)

pkg/controller/common/utils.go Outdated Show resolved Hide resolved
pkg/controller/lifecycle/actuator.go Show resolved Hide resolved
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 18, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 18, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 18, 2024
marc1404
marc1404 approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@marc1404 marc1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks a lot :) I was wondering about the indirection as well. Looks great!

@marc1404 marc1404 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 18, 2024
@MartinWeindel MartinWeindel merged commit 66c51a3 into master Dec 18, 2024
9 checks passed
@MartinWeindel MartinWeindel deleted the ignore-on-cpm branch December 18, 2024 10:14
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc1404 marc1404 marc1404 approved these changes

Assignees
No one assigned
Labels
area/control-plane-migration Control plane migration related kind/bug Bug reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MartinWeindel @marc1404 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot