Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reconcile annotation on reconciliation #406

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Remove reconcile annotation on reconciliation #406

merged 3 commits into from
Dec 13, 2024

Conversation

MartinWeindel
Copy link
Member

@MartinWeindel MartinWeindel commented Dec 13, 2024 •
edited
Loading

What this PR does / why we need it:
Currently, there is no reliable way to check if a DNSEntry has been reconciled.
With this PR, if the entry is annotated with the standard Gardener annotation gardener.cloud/operation=reconcile, this annotation is removed during reconciliation again.
This can be used to verify that a DNSEntry resource has been reconciled at least once.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
This is needed for a bug fix for the restore step of the control plane migration. See gardener/gardener-extension-shoot-dns-service#408

Release note:

Remove annotation `gardener.cloud/operation=reconcile` on reconciliation

@MartinWeindel MartinWeindel requested a review from a team as a code owner December 13, 2024 12:45
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Dec 13, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 13, 2024
@MartinWeindel MartinWeindel mentioned this pull request Dec 13, 2024
Merged
@gardener-robot gardener-robot added size/s Size of pull request is small (see gardener-robot robot/bots/size.py) and removed size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Dec 13, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 13, 2024
@marc1404 marc1404 force-pushed the handle-reconcile-annotation branch from 5192e01 to 8b4244f Compare December 13, 2024 13:50
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 13, 2024
marc1404
marc1404 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@marc1404 marc1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it makes sense to support the expected behavior around gardener.cloud/operation=reconcile as well!

I added a small integration test case to cover the removal of the annotation after reconciliation.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 13, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 13, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 13, 2024
@marc1404 marc1404 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 13, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 13, 2024
@MartinWeindel MartinWeindel merged commit 02c1a28 into master Dec 13, 2024
12 checks passed
@MartinWeindel MartinWeindel deleted the handle-reconcile-annotation branch December 13, 2024 17:25
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc1404 marc1404 marc1404 approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MartinWeindel @marc1404 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot