Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for projected volume kubeconfig #73

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

ialidzhikov
Copy link
Member

How to categorize this PR?

/area security
/kind enhancement

What this PR does / why we need it:
This PR adds the option to configure a projected volume for the validator which can be used as a kubeconfig. It is for example needed, if operators generate their kubeconfigs for the virtual garden cluster via the TokenRequestor.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
Similar to gardener/gardener-extension-provider-aws#791

Release note:

NONE

@gardener-prow gardener-prow bot added area/security Security related kind/enhancement Enhancement, improvement, extension labels Oct 18, 2023
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 18, 2023
@ialidzhikov
Copy link
Member Author

/approve

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2023
Copy link
Contributor

@dimitar-kostadinov dimitar-kostadinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Oct 18, 2023

LGTM label has been added.

Git tree hash: 1cc497a22ff8e6da38f0baba1a9be63baec8fae1

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dimitar-kostadinov, ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dimitar-kostadinov,ialidzhikov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot merged commit 0d8dbbc into gardener:main Oct 18, 2023
1 check passed
@ialidzhikov ialidzhikov deleted the enh/admission-kubeconfig branch October 19, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/security Security related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants