Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for projected volume kubeconfig #791

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Add support for projected volume kubeconfig #791

merged 2 commits into from
Aug 14, 2023

Conversation

timuthy
Copy link
Member

@timuthy timuthy commented Aug 11, 2023

How to categorize this PR?

/area security
/kind enhancement
/platform aws

What this PR does / why we need it:
This PR adds the option to configure a projected volume for the validator which can be used as a kubeconfig. It is for example needed, if operators generate their kubeconfigs for the virtual garden cluster via the TokenRequestor.

Release note:

The `gardener-extension-admission-aws` chart allows to optionally configure a projected volume based kubeconfig.

@timuthy timuthy requested review from a team as code owners August 11, 2023 16:09
@gardener-robot gardener-robot added area/security Security related kind/enhancement Enhancement, improvement, extension platform/aws Amazon web services platform/infrastructure needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Aug 11, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 11, 2023
@kon-angelo kon-angelo added this to the v1.46 milestone Aug 14, 2023
kon-angelo
kon-angelo previously approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Aug 14, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 14, 2023
@gardener-robot gardener-robot added needs/review Needs review and removed needs/review Needs review labels Aug 14, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 14, 2023
kon-angelo
kon-angelo approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kon-angelo kon-angelo merged commit 70f95e6 into gardener:master Aug 14, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 14, 2023
@timuthy timuthy deleted the enhancement.validator-kubeconfig branch August 14, 2023 14:24
@ialidzhikov ialidzhikov mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
area/security Security related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/aws Amazon web services platform/infrastructure reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v1.46
Development

Successfully merging this pull request may close these issues.
5 participants
@timuthy @kon-angelo @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot