Explicitly set the PVC's storageClassName to default
#51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
gardener-prow
bot
added
the
size/XS
96 tasks
gardener-prow
bot
added
cla: no
ialidzhikov
force-pushed
the
fix/storage-class-assignment
branch
from
c07ed17 to
7b85be4
Compare
ialidzhikov
force-pushed
the
fix/storage-class-assignment
branch
from
7b85be4 to
40a6d73
Compare
gardener-prow
bot
added
size/S
gardener-prow
bot
removed
the
do-not-merge/work-in-progress
In the registry-cache extension we deploy PVCs to the Shoot. We see cases where the PVC and StorageClass creation can be racy. In K8s < 1.26, when the default StorageClass is created after the PVC, the PVC hangs in Pending state with reason `no persistent volumes available for this claim and no storage class is set`. In K8s, there is a feature gate called `RetroactiveDefaultStorageClass` which makes possible the StorageClass from PVC to be set when the PVC is created before the StorageClass. See https://kubernetes.io/docs/concepts/storage/persistent-volumes/#retroactive-default-storageclass-assignment In the registry-cache extension we decided to hard-code the StorageClass name to `default` for time being. When it is ensured that `RetroactiveDefaultStorageClass` is enabled by default in the supported K8s versions, then we can drop this.
gardener/[email protected] contains cherry-pick of gardener/gardener#8565.
ialidzhikov
force-pushed
the
fix/storage-class-assignment
branch
from
db671de to
7b41748
Compare
|
/approve |
gardener-prow
bot
added
the
approved
ialidzhikov
force-pushed
the
fix/storage-class-assignment
branch
from
629740b to
de70605
Compare
|
LGTM label has been added. Git tree hash: 81ff1d8557f1c79d508f87c1f508f37a52e3f86c
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dimitar-kostadinov, ialidzhikov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind bug
What this PR does / why we need it:
In the registry-cache extension we deploy PVCs to the Shoot. We see cases where the PVC and StorageClass creation can be racy. In K8s < 1.26, when the default StorageClass is created after the PVC, the PVC hangs in Pending state with reason
no persistent volumes available for this claim and no storage class is set. In K8s, there is a feature gate calledRetroactiveDefaultStorageClasswhich makes possible the StorageClass from PVC to be set when the PVC is created before the StorageClass. See https://kubernetes.io/docs/concepts/storage/persistent-volumes/#retroactive-default-storageclass-assignment In the registry-cache extension we decided to hard-code the StorageClass name todefaultfor time being. When it is ensured thatRetroactiveDefaultStorageClassis enabled by default in the supported K8s versions, then we can drop this.UPDATE: We need to explicitly set the spec.storageClassName to default as marking the Gardener managed StorageClass as the default one is configurable on provider extensions side. For example, for provider-aws see the storage.managedDefaultClass field in the ControlPlaneConfig (https://github.com/gardener/gardener-extension-provider-aws/blob/v1.48.0/docs/usage/usage.md#controlplaneconfig).
Which issue(s) this PR fixes:
Part of #3
Special notes for your reviewer:
✅
The PR depends on gardener/gardener#8565 to make the e2e tests happy.Release note: