Skip to content

Commit

Permalink
Update comment
Browse files Browse the repository at this point in the history
  • Loading branch information
ialidzhikov committed Oct 16, 2023
1 parent 703193a commit 629740b
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions pkg/component/registrycaches/registrycaches.go
Original file line number Diff line number Diff line change
Expand Up @@ -271,9 +271,8 @@ func computeResourcesDataForRegistryCache(cache *v1alpha1.RegistryCache, image s
corev1.ResourceStorage: *cache.Size,
},
},
// TODO(ialidzhikov): Currently the PVC and StorageClass creation is racy. If PVC gets created before the StorageClass, then it hangs in Pending state with reason "no persistent volumes available for this claim and no storage class is set".
// There is a K8s feature called RetroactiveDefaultStorageClass that aims to fix the above-described behaviour. See https://kubernetes.io/docs/concepts/storage/persistent-volumes/#retroactive-default-storageclass-assignment.
// Consider dropping this when the extension no longer supports a K8s version where the RetroactiveDefaultStorageClass feature gate is not enabled by default (K8s < 1.26).
// We need to explicitly set the spec.storageClassName to default as marking the Gardener managed default StorageClass as the default one is configurable on provider extensions side.
// For example, for provider-aws see the storage.managedDefaultClass field in the ControlPlaneConfig (https://github.com/gardener/gardener-extension-provider-aws/blob/v1.48.0/docs/usage/usage.md#controlplaneconfig).
StorageClassName: pointer.String("default"),
},
},
Expand Down

0 comments on commit 629740b

Please sign in to comment.