Vendor [email protected] and Upgrade k8s dependencies and controller-runtime
#12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade k8s dependencies to `v0.26.1` Upgrade controller-runtime to `v0.14.4`
Now we have a linter for grouping imports.
gardener-prow
bot
added
area/open-source
|
/hold |
gardener-prow
bot
added
cla: yes
gardener-prow
bot
added
the
do-not-merge/work-in-progress
Gardener now checks all the ManagedResources in the shoot controlplane which does not specify `spec.class`, so these MRs are already covered.
shafeeqes
force-pushed
the
vendor/[email protected]
branch
from
ff8a052 to
ed7c088
Compare
gardener-prow
bot
removed
the
do-not-merge/work-in-progress
shafeeqes
force-pushed
the
vendor/[email protected]
branch
from
dcd7377 to
b7fdc3b
Compare
|
/hold cancel |
gardener-prow
bot
removed
the
do-not-merge/hold
|
very good, thanks 🚀 |
|
LGTM label has been added. Git tree hash: f452323df5e9be6e83d60580dc5792ae0177696c
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oliver-goetz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
This was referenced Mar 9, 2023
ialidzhikov
added a commit
to ialidzhikov/gardener-extension-registry-cache
that referenced
this pull request
Aug 18, 2023
Follow-up after gardener#12
ialidzhikov
added a commit
to ialidzhikov/gardener-extension-registry-cache
that referenced
this pull request
Aug 31, 2023
Follow-up after gardener#12
gardener-prow bot
pushed a commit
that referenced
this pull request
Sep 4, 2023
* Update VPA's `apiVersion` from `autoscaling.k8s.io/v1beta2` to `autoscaling.k8s.io/v1` Similar to gardener/gardener-extension-provider-aws@5c0592e * Add liveness and readiness probe to the extension Pods Similar to gardener/gardener-extension-provider-aws#497 * Remove `minAllowed.cpu` from the registry-cache extension and admission VPAs Similar to gardener/gardener-extension-provider-aws#711 * Make the `gardener-extension-registry-cache-admission` Service topology-aware Similar to gardener/gardener-extension-provider-aws#732 and gardener/gardener-extension-provider-aws#750 * Make the metrics port configurable Follow-up after #12 * Adapt `NetworkPolicy`s for the admission Similar to gardener/gardener-extension-provider-aws@02182f9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area open-source
/kind enhancement
What this PR does / why we need it:
Vendor gardener
v1.65.0Upgrade k8s dependencies and controller-runtime
Which issue(s) this PR fixes:
Special notes for your reviewer:
I have removed the health check controller, since there was only one health check for ManagedResource and condition
ShootSystemComponentsHealthy, these are already health checked by gardener now. If you need to add some specific error code checks or add health check for some other condition, this controller shall be added again.Release note: