Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topology-aware routing: Adapt to the upstream annotation change in K8s 1.27 #750

Merged
merged 3 commits into from
May 22, 2023

Conversation

ialidzhikov
Copy link
Member

How to categorize this PR?

/area high-availability
/area networking
/kind enhancement
/platform aws

What this PR does / why we need it:
See gardener/gardener#7933

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
N/A

Release note:

NONE

@ialidzhikov ialidzhikov requested review from a team as code owners May 15, 2023 13:59
@gardener-robot gardener-robot added area/high-availability High availability related area/networking Networking related kind/enhancement Enhancement, improvement, extension platform/aws Amazon web services platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels May 15, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 15, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 15, 2023
@ialidzhikov ialidzhikov force-pushed the enh/topology-mode-annotation branch from d612ead to 34623a0 Compare May 15, 2023 14:10
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 15, 2023
@ialidzhikov ialidzhikov force-pushed the enh/topology-mode-annotation branch from 34623a0 to d565b13 Compare May 15, 2023 14:21
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 15, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 15, 2023
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 22, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 22, 2023
@kon-angelo kon-angelo merged commit c5c9386 into gardener:master May 22, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 22, 2023
ialidzhikov added a commit to ialidzhikov/gardener-extension-registry-cache that referenced this pull request Aug 18, 2023
ialidzhikov added a commit to ialidzhikov/gardener-extension-registry-cache that referenced this pull request Aug 31, 2023
gardener-prow bot pushed a commit to gardener/gardener-extension-registry-cache that referenced this pull request Sep 4, 2023
* Update VPA's `apiVersion`

from `autoscaling.k8s.io/v1beta2` to `autoscaling.k8s.io/v1`

Similar to gardener/gardener-extension-provider-aws@5c0592e

* Add liveness and readiness probe to the extension Pods

Similar to gardener/gardener-extension-provider-aws#497

* Remove `minAllowed.cpu` from the registry-cache extension and admission VPAs

Similar to gardener/gardener-extension-provider-aws#711

* Make the `gardener-extension-registry-cache-admission` Service topology-aware

Similar to gardener/gardener-extension-provider-aws#732 and gardener/gardener-extension-provider-aws#750

* Make the metrics port configurable

Follow-up after #12

* Adapt `NetworkPolicy`s for the admission

Similar to gardener/gardener-extension-provider-aws@02182f9
@ialidzhikov ialidzhikov deleted the enh/topology-mode-annotation branch September 18, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/high-availability High availability related area/networking Networking related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/aws Amazon web services platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants