Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes Version Configurability per Worker Pool #202

Merged
merged 2 commits into from
Jan 25, 2022

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented Jan 22, 2022

How to categorize this PR?

/area usability
/kind enhancement
/platform vsphere
/merge squash

What this PR does / why we need it:
This PR implements support for gardener/gardener's WorkerPoolKubernetesVersion feature gate. Since there are neither CSI migration nor any Kubernetes version specific constraints in the kubelet configuration, the only task is documenting that it supports the feature with the next release.

Which issue(s) this PR fixes:
Part of gardener/gardener#3501

Special notes for your reviewer:
Depends on #200, hence, PR is in draft state.

Release note:

This extension does now support `gardener/gardener`'s `WorkerPoolKubernetesVersion` feature gate, i.e., having [worker pools with overridden Kubernetes versions](https://github.com/gardener/gardener/blob/8a9c88866ec5fce59b5acf57d4227eeeb73669d7/example/90-shoot.yaml#L69-L70).

@gardener-robot gardener-robot added area/usability Usability related kind/enhancement Enhancement, improvement, extension merge/squash Should be merged via 'Squash and merge' platform/vsphere VMware vSphere platform/infrastructure needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Jan 22, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 22, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 22, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 22, 2022
@gardener-robot gardener-robot added the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label Jan 24, 2022
@rfranzke
Copy link
Member Author

/ready

@gardener-robot gardener-robot removed the size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) label Jan 24, 2022
@gardener-robot gardener-robot marked this pull request as ready for review January 24, 2022 19:54
@gardener-robot gardener-robot requested review from a team as code owners January 24, 2022 19:54
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 24, 2022
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jan 25, 2022
@MartinWeindel MartinWeindel merged commit 509a8ac into gardener:master Jan 25, 2022
@rfranzke rfranzke deleted the enh/kubeletversion branch January 25, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/usability Usability related kind/enhancement Enhancement, improvement, extension merge/squash Should be merged via 'Squash and merge' needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/vsphere VMware vSphere platform/infrastructure reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants