Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revendor gardener/[email protected] #200

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Revendor gardener/[email protected] #200

merged 1 commit into from
Jan 24, 2022

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented Jan 20, 2022 •
edited
Loading

How to categorize this PR?

/area security
/kind enhancement
/merge squash

What this PR does / why we need it:
Revendor gardener/[email protected].

Special notes for your reviewer:
✅ Depends on #187, hence, PR is in draft state.
✅ Depends on gardener/[email protected] release, hence, PR is in draft state.

Release note:

NONE

@gardener-robot gardener-robot added area/security Security related kind/enhancement Enhancement, improvement, extension merge/squash Should be merged via 'Squash and merge' needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Jan 20, 2022
@rfranzke rfranzke mentioned this pull request Jan 20, 2022
Merged
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 20, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 20, 2022
This was referenced Jan 21, 2022
Closed
Closed
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 22, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 22, 2022
This was referenced Jan 22, 2022
Merged
Merged
@rfranzke
Copy link
Member Author

/ready
/invite @timuthy

@gardener-robot gardener-robot marked this pull request as ready for review January 24, 2022 11:45
@gardener-robot gardener-robot requested review from a team as code owners January 24, 2022 11:45
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 24, 2022
MartinWeindel
MartinWeindel approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

tested shoot creation & deletion.

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jan 24, 2022
@MartinWeindel
Copy link
Member

/cla

@gardener-robot
Copy link

@MartinWeindel I reached out successfully to the cla-assistant to recheck this pull request.

@MartinWeindel MartinWeindel merged commit d23af22 into gardener:master Jan 24, 2022
@rfranzke rfranzke deleted the revendor/gardener-v1.39 branch January 24, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinWeindel MartinWeindel MartinWeindel approved these changes

@timuthy timuthy Awaiting requested review from timuthy

Assignees
No one assigned
Labels
area/security Security related kind/enhancement Enhancement, improvement, extension merge/squash Should be merged via 'Squash and merge' needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rfranzke @MartinWeindel @gardener-robot @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3