Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new metric that will allow Prometheus to scrape the stale machi… #612

Merged
merged 1 commit into from
May 3, 2023
Merged

Add a new metric that will allow Prometheus to scrape the stale machi… #612

merged 1 commit into from
May 3, 2023

Conversation

jguipi
Copy link
Contributor

@jguipi jguipi commented Apr 25, 2023 •
edited
Loading

How to categorize this PR?
/area monitoring
/kind enhancement

What this PR does / why we need it:
Add a new metric that will allow Prometheus to scrape the stale machine count.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Add a new metric that will allow Prometheus to scrape the stale machine count.

@jguipi jguipi requested review from a team as code owners April 25, 2023 15:58
This was referenced Apr 25, 2023
Merged
Merged
Merged
@gardener-robot gardener-robot added area/monitoring Monitoring (including availability monitoring and alerting) related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Apr 25, 2023
@jguipi jguipi mentioned this pull request Apr 25, 2023
Merged
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 25, 2023
This was referenced Apr 25, 2023
Merged
Merged
Merged
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 25, 2023
kon-angelo
kon-angelo approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 3, 2023
@kon-angelo kon-angelo merged commit 52b907b into gardener:master May 3, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 3, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
area/monitoring Monitoring (including availability monitoring and alerting) related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jguipi @kon-angelo @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot