Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new metric that will allow Prometheus to scrape the stale machine count #596

Merged
merged 1 commit into from
May 18, 2023
Merged

Add a new metric that will allow Prometheus to scrape the stale machine count #596

merged 1 commit into from
May 18, 2023

Conversation

jguipi
Copy link
Contributor

@jguipi jguipi commented Apr 25, 2023 •
edited
Loading

How to categorize this PR?
/area monitoring
/kind enhancement

What this PR does / why we need it:
Add a new metric that will allow Prometheus to scrape the stale machine count.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Add a new metric that will allow Prometheus to scrape the stale machine count.

@jguipi
Update configmap-monitoring.yaml
728afe8 
Add a new metric that will allow Prometheus to scrape the stale machine count
@jguipi jguipi requested review from a team as code owners April 25, 2023 15:58
@gardener-robot gardener-robot added area/monitoring Monitoring (including availability monitoring and alerting) related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Apr 25, 2023
This was referenced Apr 25, 2023
Merged
Merged
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 25, 2023
This was referenced Apr 25, 2023
Merged
Merged
Merged
Merged
Merged
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 25, 2023
@shaoyongfeng
Copy link
Contributor

Hi @jguipi ,
can I merge this PR now? or I have to wait for gardener/machine-controller-manager#808 got merged?

@jguipi
Copy link
Contributor Author

jguipi commented May 18, 2023

Hi @jguipi , can I merge this PR now? or I have to wait for gardener/machine-controller-manager#808 got merged?

Since other similar PR has been merged, I think we can merge this one as well.

@kevin-lacoo kevin-lacoo merged commit fc183eb into gardener:master May 18, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaoyongfeng shaoyongfeng shaoyongfeng approved these changes

Assignees
No one assigned
Labels
area/monitoring Monitoring (including availability monitoring and alerting) related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jguipi @shaoyongfeng @gardener-robot-ci-1 @kevin-lacoo @gardener-robot-ci-2 @gardener-robot