infrastructure flow reconciler #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot
added
kind/api-change
gardener-robot-ci-2
added
needs/ok-to-test
gardener-robot-ci-1
added
reviewed/ok-to-test
kon-angelo
force-pushed
the
terraform-remove-new
branch
from
c43b2fb to
3ca4f7e
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
reviewed/ok-to-test
|
Testrun: e2e-dtd7r +---------------------+---------------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------------+-----------+----------+ | infrastructure-test | infrastructure-test | Failed | 41m27s | | infrastructure-test | infra-flow-test | Failed | 32m3s | | infrastructure-test | infra-flow-migration-test | Failed | 43m29s | | bastion-test | bastion-test | Succeeded | 11m11s | +---------------------+---------------------------+-----------+----------+ |
gardener-robot-ci-2
added
the
reviewed/ok-to-test
|
Testrun: e2e-6jrp7 +---------------------+---------------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------------+-----------+----------+ | bastion-test | bastion-test | Succeeded | 10m46s | | infrastructure-test | infrastructure-test | Failed | 44m2s | | infrastructure-test | infra-flow-test | Failed | 41m38s | | infrastructure-test | infra-flow-migration-test | Failed | 46m32s | +---------------------+---------------------------+-----------+----------+ |
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
kon-angelo
force-pushed
the
terraform-remove-new
branch
from
bad7a3f to
d40f2cb
Compare
|
Testrun: e2e-lrwn4 +---------------------+---------------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------------+-----------+----------+ | bastion-test | bastion-test | Succeeded | 12m53s | | infrastructure-test | infrastructure-test | Succeeded | 34m35s | | infrastructure-test | infra-flow-test | Succeeded | 27m20s | | infrastructure-test | infra-flow-migration-test | Failed | 35m34s | +---------------------+---------------------------+-----------+----------+ |
|
/test |
|
Testrun: e2e-dhp5m +---------------------+---------------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------------+-----------+----------+ | bastion-test | bastion-test | Succeeded | 12m22s | | infrastructure-test | infra-flow-migration-test | Succeeded | 33m54s | | infrastructure-test | infrastructure-test | Succeeded | 31m58s | | infrastructure-test | infra-flow-test | Succeeded | 27m4s | +---------------------+---------------------------+-----------+----------+ |
There was a problem hiding this comment.
Should we try to unify whiteboard and inventory as the state of the whiteboard is also persisted for other providers like AWS and Openstack?
Looks to me as if we have resource ids and other data in whiteboard and inventory with sometimes overlapping purposes:
- managed items (created by the infrastructure controller), persisted for providing a list of managed resources in case for manual cleanup on forced deletion
- managed or looked up resource ids and names exposed for third-party controllers.
- managed resource ids/names in state if there is no suitable place to store this information on IaaS side (like tags, etc)
- managed resource ids/names in state for informative purposes
- internal caching of resource object details to simplify code
|
thanks for the headsup @kon-angelo. Happy to see it alive! 🚀 Could you co-author me if possible in the merge commit? |
Co-authored-by: Adrian Stobbe <[email protected]>
kon-angelo
force-pushed
the
terraform-remove-new
branch
from
d40f2cb to
cf5e02b
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
|
/test |
|
Testrun: e2e-rmp4j +---------------------+---------------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------------+-----------+----------+ | bastion-test | bastion-test | Succeeded | 11m23s | | infrastructure-test | infrastructure-test | Succeeded | 33m40s | | infrastructure-test | infra-flow-test | Succeeded | 30m47s | | infrastructure-test | infra-flow-migration-test | Succeeded | 35m0s | +---------------------+---------------------------+-----------+----------+ |
gardener-robot-ci-3
added
the
reviewed/ok-to-test
|
@MartinWeindel I reimplemented the inventory on top of the whiteboard. The reason the inventory had a separate implementation rather just storing the IDs, is that it has a bit of special logic with regards to additions/deletions that would not apply for other providers. So pushing more tight integration doesn't make sense from my view. |
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
MartinWeindel
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
/lgtm
Thanks to @elchead for all the initial work and @kon-angelo for taking care of for both the big picture and all the details.
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind enhancement
/platform azure
What this PR does / why we need it:
This is a continuation from #596. Special thanks to @elchead for all the effort in the initial implementation 💯
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: