Flow-based infrastructure reconciliation without Terraformer #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevin-lacoo Labels area/todo, kind/todo do not exist. |
gardener-robot
added
needs/review
gardener-robot-ci-2
added
reviewed/ok-to-test
|
/test |
|
Testrun: e2e-l2rfq +---------------------+---------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------+-----------+----------+ | infrastructure-test | infrastructure-test | Succeeded | 23m25s | | bastion-test | bastion-test | Succeeded | 9m16s | +---------------------+---------------------+-----------+----------+ |
gardener-robot
added
area/control-plane
kevin-lacoo
changed the title
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
reviewed/ok-to-test
|
/test |
|
Testrun: e2e-xwlkv +---------------------+---------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------+-----------+----------+ | infrastructure-test | infrastructure-test | Succeeded | 24m32s | | bastion-test | bastion-test | Succeeded | 10m34s | +---------------------+---------------------+-----------+----------+ |
zkdev
added
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
|
@kon-angelo You have pull request review open invite, please check |
kevin-lacoo
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
gardener-robot-ci-3
added
the
reviewed/ok-to-test
|
/test |
|
Testrun: e2e-tc8lj +---------------------+---------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------+-----------+----------+ | infrastructure-test | infrastructure-test | Succeeded | 23m5s | | bastion-test | bastion-test | Succeeded | 9m23s | +---------------------+---------------------+-----------+----------+ |
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
gardener-robot-ci-1
added
reviewed/ok-to-test
shaoyongfeng
previously approved these changes
Nov 22, 2023
|
/test |
gardener-robot-ci-3
added
the
reviewed/ok-to-test
|
Testrun: e2e-97zzg +---------------------+---------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------+-----------+----------+ | infrastructure-test | infrastructure-test | Succeeded | 23m46s | | bastion-test | bastion-test | Succeeded | 9m23s | +---------------------+---------------------+-----------+----------+ |
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
gardener-robot-ci-1
added
reviewed/ok-to-test
shaoyongfeng
approved these changes
Nov 27, 2023
kon-angelo
reviewed
Nov 27, 2023
There was a problem hiding this comment.
/lgtm
Something that we discussed with @MartinWeindel is whether the persistentState type should reside with the other api types (pkg/apis/alicloud) and I am thinking that we should move it there for AWS too. E.g. in gardener/gardener-extension-provider-azure#739 I decided to put it there
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind enhancement
/platform alicloud
What this PR does / why we need it:
Reconciliation and deletion of infrastructure resources are managed directly with a graph flow and using Alicloud SDK client API instead of using Terraformer.
Migration for existing infrastructure resources is implemented, too.
Update Alicloud SDK to v1.62.561
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Currently, to activate the flow based infra management, the shoot or the infrastructure resource must be annotated with
alicloud.provider.extensions.gardener.cloud/use-flow=true
Release note: