Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix e2e Tests to Support HA Upgrade Label Changes #838

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Fix e2e Tests to Support HA Upgrade Label Changes #838

merged 1 commit into from
Aug 5, 2024

Conversation

seshachalam-yv
Copy link
Contributor

How to categorize this PR?

/area testing
/area high-availability
/kind bug
What this PR does / why we need it:
This PR updates the e2e test cases to handle scenarios where etcd clusters are upgraded from nonHA to HA, specifically addressing issues with network labeling during pre-deployment checks. The modifications ensure that tests will pass even when new labels are introduced during the upgrade process.

Which issue(s) this PR fixes:
Fixes #837

Special notes for your reviewer:

Release note:

Updated e2e tests to support label changes during HA upgrades, preventing the reconciliation process from getting stuck and ensuring smooth transitions in deployment scenarios.

@seshachalam-yv seshachalam-yv requested a review from a team as a code owner July 22, 2024 14:56
@gardener-robot gardener-robot added needs/review Needs review area/high-availability High availability related area/testing Testing related kind/bug Bug size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jul 22, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 22, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 22, 2024
@ishan16696 ishan16696 added this to the v0.23.0 milestone Aug 1, 2024
shreyas-s-rao
shreyas-s-rao approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Aug 5, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 5, 2024
@seshachalam-yv seshachalam-yv merged commit d460728 into gardener:master Aug 5, 2024
11 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 5, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyas-s-rao shreyas-s-rao shreyas-s-rao approved these changes

Assignees

@shreyas-s-rao shreyas-s-rao

Labels
area/high-availability High availability related area/testing Testing related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.23.0
Development

Successfully merging this pull request may close these issues.

To add dummy networking labels in druid e2e tests
7 participants
@seshachalam-yv @shreyas-s-rao @gardener-robot-ci-1 @ishan16696 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot