Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaces the use of etcd-custom-image with etcd-wrapper in tests #638

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Replaces the use of etcd-custom-image with etcd-wrapper in tests #638

merged 1 commit into from
Jul 12, 2023

Conversation

aaronfern
Copy link
Contributor

@aaronfern aaronfern commented Jul 11, 2023 •
edited by shreyas-s-rao
Loading

How to categorize this PR?

/area testing
/kind technical-debt

What this PR does / why we need it:
This PR updates a few test files that still refer and use etcd-custom-image to their tests. These files now use etcd-wrapper to run their tests

Which issue(s) this PR fixes:
Fixes #609

Special notes for your reviewer:

Release note:

NONE

@aaronfern aaronfern requested a review from a team as a code owner July 11, 2023 12:05
@gardener-robot gardener-robot added area/testing Testing related kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jul 11, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 11, 2023
@aaronfern
Copy link
Contributor Author

/test pull-etcd-druid-e2e-kind

2 similar comments
@aaronfern
Copy link
Contributor Author

/test pull-etcd-druid-e2e-kind

@seshachalam-yv
Copy link
Contributor

/test pull-etcd-druid-e2e-kind

seshachalam-yv
seshachalam-yv approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@seshachalam-yv seshachalam-yv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jul 11, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 11, 2023
shreyas-s-rao
shreyas-s-rao approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@shreyas-s-rao shreyas-s-rao merged commit b4d722f into gardener:master Jul 12, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seshachalam-yv seshachalam-yv seshachalam-yv approved these changes

@shreyas-s-rao shreyas-s-rao shreyas-s-rao approved these changes

Assignees

@aaronfern aaronfern

Labels
area/testing Testing related kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

☂️ Replace etcd-custom-image with etcd-wrapper
5 participants
@aaronfern @seshachalam-yv @shreyas-s-rao @gardener-robot-ci-3 @gardener-robot