Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☂️ Replace etcd-custom-image with etcd-wrapper #609

Closed
6 tasks done
Tracked by #612
unmarshall opened this issue Jun 5, 2023 · 3 comments · Fixed by #638
Closed
6 tasks done
Tracked by #612

☂️ Replace etcd-custom-image with etcd-wrapper #609

unmarshall opened this issue Jun 5, 2023 · 3 comments · Fixed by #638
Assignees
Labels
kind/enhancement Enhancement, improvement, extension kind/epic Large multi-story topic status/closed Issue is closed (either delivered or triaged)

Comments

@unmarshall
Copy link
Contributor

unmarshall commented Jun 5, 2023

How to categorize this issue?

/kind enhancement

What would you like to be added

etcd-custom-image is going to be removed. See Issue and the respective PR.

Motivation (Why is this needed?)

See the reasons captured in Issue

Acceptance Criteria

Run e2e tests and g/g tests with etcd-wrapper instead of etcd-custom-image and all tests should pass.

@unmarshall unmarshall added the kind/epic Large multi-story topic label Jun 5, 2023
@gardener-robot gardener-robot added the kind/enhancement Enhancement, improvement, extension label Jun 5, 2023
@ishan16696
Copy link
Member

I would like to add/suggest one more thing as acceptance criteria:
We should be able to mimic every possible condition/scenario via ephemeral containers for debugging purposes of etcd cluster as one of such requirement I mentioned here gardener/etcd-wrapper#3 (comment)

@shreyas-s-rao shreyas-s-rao changed the title Replace etcd-custom-image with etcd-wrapper ☔ Replace etcd-custom-image with etcd-wrapper Jun 5, 2023
@shreyas-s-rao shreyas-s-rao changed the title ☔ Replace etcd-custom-image with etcd-wrapper ☂️ Replace etcd-custom-image with etcd-wrapper Jun 5, 2023
@shreyas-s-rao
Copy link
Contributor

Change README to reflect the image change

@unmarshall etcd-druid does not mention etcd-custom-image anywhere in the repo, except in the charts/images.yaml file, which will anyway be replaced by etcd-wrapper. I think adding this change to the README should be part of an overall overhaul of the druid docs, and should not be a subtask for this umbrella issue. WDYT?

@unmarshall
Copy link
Contributor Author

unmarshall commented Jul 11, 2023

I think adding this change to the README should be part of an overall overhaul of the druid docs, and should not be a subtask for this umbrella issue. WDYT?

Ok that is fine. We do not have to do this now. I think you have another issue for overhauling the doc for druid. Can you add this point as one of the things to be done in that task?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension kind/epic Large multi-story topic status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants