Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error handling for initial delta snapshot #166

Merged
merged 2 commits into from
Jun 12, 2019
Merged

Fix error handling for initial delta snapshot #166

merged 2 commits into from
Jun 12, 2019

Conversation

swapnilgm
Copy link
Contributor

What this PR does / why we need it:
This PR is cherry pick of #165 and #164
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

In the case that initial delta snapshot fails, a full snapshot is tried instead.

@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 12, 2019
amshuman-kr
amshuman-kr approved these changes Jun 12, 2019
View reviewed changes
Copy link
Collaborator

@amshuman-kr amshuman-kr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swapnilgm swapnilgm added the reviewed/lgtm Has approval for merging label Jun 12, 2019
@swapnilgm swapnilgm merged commit a95be60 into gardener:rel-0.6.0 Jun 12, 2019
@swapnilgm swapnilgm deleted the hotfix/compact-version branch June 12, 2019 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amshuman-kr amshuman-kr amshuman-kr approved these changes

@georgekuruvillak georgekuruvillak Awaiting requested review from georgekuruvillak

@shreyas-s-rao shreyas-s-rao Awaiting requested review from shreyas-s-rao

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swapnilgm @amshuman-kr @gardener-robot-ci-1 @shreyas-s-rao